Remove Twitter::Configuration::VALID_FORMATS since it was only being …

…used in specs
sferik · Jun 24, 2011 · a04e828 · a04e828
1 parent 0b91afa
commit a04e828
Show file tree

Hide file tree

Showing 18 changed files with 17 additions and 24 deletions.
diff --git a/lib/twitter/configuration.rb b/lib/twitter/configuration.rb
@@ -18,13 +18,6 @@ module Configuration
       :search_endpoint,
       :user_agent].freeze
 
-    # An array of valid request/response formats
-    #
-    # @note Not all methods support the XML format.
-    VALID_FORMATS = [
-      :json,
-      :xml].freeze
-
     # The adapter that will be used to connect if none is set
     #
     # @note The default faraday adapter is Net::HTTP.

diff --git a/spec/twitter/client/account_spec.rb b/spec/twitter/client/account_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/block_spec.rb b/spec/twitter/client/block_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/direct_messages_spec.rb b/spec/twitter/client/direct_messages_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/favorites_spec.rb b/spec/twitter/client/favorites_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/friends_and_followers_spec.rb b/spec/twitter/client/friends_and_followers_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/friendship_spec.rb b/spec/twitter/client/friendship_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/legal_spec.rb b/spec/twitter/client/legal_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/list_members_spec.rb b/spec/twitter/client/list_members_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/list_spec.rb b/spec/twitter/client/list_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/list_subscribers_spec.rb b/spec/twitter/client/list_subscribers_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/local_trends_spec.rb b/spec/twitter/client/local_trends_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/notification_spec.rb b/spec/twitter/client/notification_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/saved_searches_spec.rb b/spec/twitter/client/saved_searches_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/spam_reporting_spec.rb b/spec/twitter/client/spam_reporting_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/timeline_spec.rb b/spec/twitter/client/timeline_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/tweets_spec.rb b/spec/twitter/client/tweets_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')

diff --git a/spec/twitter/client/user_spec.rb b/spec/twitter/client/user_spec.rb
@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Twitter::Client do
-  Twitter::Configuration::VALID_FORMATS.each do |format|
+  %w(json xml).each do |format|
     context ".new(:format => '#{format}')" do
       before do
         @client = Twitter::Client.new(:format => format, :consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')