Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug fix for iterating over friends or followers of someone else than the authenticated user #335

Merged
merged 4 commits into from Dec 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

nbraem commented Dec 20, 2012

This code:

twitter.followers("sferik").each{}

Generates these requests:

get https://api.twitter.com/1.1/followers/list.json?cursor=-1&screen_name=sferik
get https://api.twitter.com/1.1/account/verify_credentials.json
get https://api.twitter.com/1.1/followers/list.json?screen_name=nbraem&cursor=1421602433033067513
...

As you can see, the first request correctly returns the followers of sferik, but the second request returns followers of the authenticated user nbraem.

This was not caught in the specs, because it's always authenticating as sferik, and requesting followers or friends of the same user sferik.

sferik added a commit that referenced this pull request Dec 20, 2012

Merge pull request #335 from nbraem/master
Bug fix for iterating over friends or followers of someone else than the authenticated user

@sferik sferik merged commit 316d319 into sferik:master Dec 20, 2012

Owner

sferik commented Dec 20, 2012

Thanks. I'll push out a release including this fix later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment