Fixing issue with wrong signature being generated when multipart data is posted. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted when multipart data is posted. The `request` method on Twitter::Client gets signature_params but doesn't pass that along to `request_setup` method breaking the signature on multipart posts. This fix adds the missing extra param to `request_setup` and uses it when generating the OAuth signature.
|
Hi, Thanks for finding the root cause of this issue. It seems I have inadvertently introduced this subtle bug while refactoring the request handling methods. Do you mind adding a test case that makes sure that we don't have any more regressions in this area of the code (vis-a-vis respecting the |
|
I'm not terribly familiar with rspec, let me see what I can do. |
|
Thanks for adding tests, mind fixing this typo? persent should be present |
|
This looks fine. I’ll fix the typo after the merge. |
sferik
added a commit
that referenced
this pull request
Jun 11, 2013
Fixing issue with wrong signature being generated when multipart data is posted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes released in 4.7.0 broke at least update_with_media API method.
Any multipart request shouldn't have it's POST parameters included while generating the OAuth signature.
The
requestmethod on Twitter::Client gets signature_params butdoesn't pass that along to
request_setupmethod breaking the signatureon multipart posts.
This fix adds the missing extra param to
request_setupand uses itwhen generating the OAuth signature.