Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video upload support #755

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Add video upload support #755

merged 1 commit into from
Jan 19, 2016

Conversation

fx
Copy link
Contributor

@fx fx commented Jan 19, 2016

Clean rebase, since things seem to have exploded over at #705

Adds media/upload support for chunked video uploads.

See:
https://dev.twitter.com/rest/public/uploading-media
https://blog.twitter.com/2015/rest-api-now-supports-native-video-upload

sferik added a commit that referenced this pull request Jan 19, 2016
@sferik sferik merged commit 1b74de1 into sferik:master Jan 19, 2016
@sferik
Copy link
Owner

sferik commented Jan 19, 2016

👍 Thanks for opening a new pull request.

The master branch won’t be released until the v6, which could be a while from now. Would you have any interest in backporting this to the 5-stable branch, which I was planning to release in the next couple days? I’d love to get this into the next release.

@PuKoren
Copy link

PuKoren commented Jan 19, 2016

👍 would love too!

@maxschmeling
Copy link

I get the following error with files over 30 seconds: "Twitter::Error::BadRequest: Large file can not be finalized synchronously." Do you have any idea how to fix it? Can it be fixed? Or does the endpoint just not support files > 30 seconds like the documentation says. I'm just trying to figure out if it's possible to upload videos up to the 10 minute maximum...

Happy to contribute the fix if you can point me in the right direction. (if there is a fix)

@maxschmeling
Copy link

There seems to be very little information about videos with 10 minute limit. I'm guessing it's something only allowed through the Twitter family of apps. If you know differently, please let me know. Thanks

@PuKoren
Copy link

PuKoren commented Feb 5, 2016

What is the size in MB of your video?

@maxschmeling
Copy link

17.9 MB

@maxschmeling
Copy link

The code in this pull requests appears to be using the chunked upload automatically... unless I'm missing something.

@PuKoren
Copy link

PuKoren commented Feb 5, 2016

You are right, I was looking at the wrong direction

@fx
Copy link
Contributor Author

fx commented Feb 15, 2016

@sferik sorry, somehow didn't get notifications here. I'm swamped currently, but if I find a minute I'll backport it.

@ArslanKathia
Copy link

any example or api class to upload the media and get response back in the form of media ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants