Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload video multipart #870

Closed
wants to merge 1 commit into from

Conversation

mostafa-kenawey
Copy link

Hello,
Uploading 2 minutes videos wasn't working at all, i added the attribute "media_category" to the INIT request and added check status to check the state of video processing before tweet with media.

Thanks

@nightsurge
Copy link

I just recently did a very similar fix for my uses.

I would recommend maybe a small sleep in the "check_status()" method? Not sure how long it takes to process the video, or how fast their requests respond, or how many they can "handle" but maybe a modest sleep of 1 second for every "in_progress" or != "succeeded" check_status() result?

Also, since you are not doing anything with the return, you may want to just "return if ..."
Oh and lastly, I do not see a "retry" count so what would happen if something got hung up on their end but didn't correctly set the status to failed? Hypothetical, but maybe a retry max to prevent an infinite loop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants