Skip to content

Commit

Permalink
Disable netcdf4 compression kwarg for the moment
Browse files Browse the repository at this point in the history
  • Loading branch information
sfinkens committed Mar 13, 2023
1 parent 8f30b2b commit c2b6d13
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions satpy/tests/writer_tests/test_cf.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,9 @@
import numpy as np
import pytest
import xarray as xr
from packaging.version import Version

from satpy import Scene
from satpy.tests.utils import make_dsq
from satpy.writers.cf_writer import _get_backend_versions

try:
from pyproj import CRS
Expand Down Expand Up @@ -1450,5 +1448,8 @@ def _get_compression_params(complevel):


def _should_use_compression_keyword():
versions = _get_backend_versions()
return versions["libnetcdf"] >= Version("4.9.0")
# libnetcdf >= 4.9.0 supports the "compression" keyword argument,
# but xarray silently ignores it at the moment. See
# https://github.com/pydata/xarray/issues/7388. Once that issue is resolved,
# check libnetcdf version here.
return False

0 comments on commit c2b6d13

Please sign in to comment.