add test feature gate to ci

sfu-db · Nov 16, 2021 · 10415b6 · 10415b6 · github-actions · Nov 17, 2021
1 parent 9ec2cbf
commit 10415b6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -115,6 +115,9 @@ jobs:
           command: clippy
           args: --features all
 
+      - name: Check each feature gate
+        run: just test-feature-gate
+
       - name: Run tests
         uses: actions-rs/cargo@v1
         with:

diff --git a/Justfile b/Justfile
@@ -9,6 +9,17 @@ build-debug:
 test +ARGS="":
     cargo test --features all {{ARGS}} -- --nocapture
 
+test-feature-gate:
+    cargo c --features src_postgres
+    cargo c --features src_mysql
+    cargo c --features src_mssql
+    cargo c --features src_sqlite
+    cargo c --features src_oracle
+    cargo c --features src_csv
+    cargo c --features src_dummy
+    cargo c --features dst_arrow
+    cargo c --features dst_arrow2
+
 bootstrap-python:
     cp README.md connectorx-python/README.md
     cd connectorx-python && poetry install

diff --git a/connectorx/Cargo.toml b/connectorx/Cargo.toml
@@ -69,8 +69,8 @@ fptr = []
 src_csv = ["csv", "regex", "chrono"]
 src_dummy = ["num-traits", "chrono"]
 src_mssql = ["rust_decimal", "num-traits", "chrono", "tiberius", "bb8-tiberius", "bb8", "tokio", "url", "uuid", "owning_ref", "futures", "urlencoding"]
-src_mysql = ["r2d2_mysql", "rust_decimal", "num-traits", "chrono", "r2d2"]
-src_oracle = ["r2d2-oracle", "chrono", "r2d2", "urlencoding"]
+src_mysql = ["r2d2_mysql", "rust_decimal", "num-traits", "chrono", "serde_json", "r2d2"]
+src_oracle = ["r2d2-oracle", "chrono", "r2d2", "urlencoding", "url"]
 src_postgres = [
   "postgres",
   "r2d2_postgres",
Benchmark suite	Current: `10415b6`	Previous: `9ec2cbf`	Ratio
`connectorx/tests/benchmarks.py::bench_mysql`	`0.06819506970934554` iter/sec (`stddev: 0.4364884711877906`)	`0.06706513754708558` iter/sec (`stddev: 1.1740166579348468`)	`0.98`
`connectorx/tests/benchmarks.py::bench_postgres`	`0.07043234358863822` iter/sec (`stddev: 1.7274786927113441`)	`0.09518679380848347` iter/sec (`stddev: 0.8101557775259912`)	`1.35`