New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eda.create_report: page design prototype #171
Comments
Looks very cool!! A couple of comments:
|
Good job Ling! For the Overview section, if there are a lot of variables there will be a lot of empty space under the statistics. I think it would be better to put the stats on top of the plots and make the plots larger. I'm concerned that if we put all of our content into one report, then it will take longer than pandas-profiling to produce. @jnwang if one of our selling points is speed, is it imperative that we don't take longer than pandas-profiling to produce the report? We could have one report that contains basically the same content as pandas-profiling that is fast to produce, and another with all of our visualizations. |
@brandonlockhart this is a good point. In my opinion, we need to make the report easy to config and define a couple of default configuration files (e.g., "pandas-profiling", "full", "minimal") for the user to select from. We can set it to "pandas-profiling" by default. |
My answers:
|
The first version is now public to everyone: https://vigilant-nobel-679808.netlify.app/ I hope we can figure out if the structure of the report is clear enough now then we can move forward to each section. Known problem: plots in overview section won't show in mobile devices because it doesn't meet the minimum required space set by bokeh. Let me know if you have any suggestion. @jnwang @jinglinpeng @dovahcrow @Waterpine @brandonlockhart @Sanjana12111994 @dylanzxc |
I really like it! My comments/questions:
|
|
This version looks much better! Great job! @eutialia I just want to comment on the plot size. The size of each plot looks pretty big on my screen, so I have to scroll up and down a lot to see everything. It would be better to make them a bit smaller. |
@jinglinpeng I like this feature. However, I think we should add it to the "full" configuration from @jnwang's above comment. I think @eutialia is currently making the pandas-profiling config (which I was thinking would be the default for |
@brandonlockhart Ic. Yes I agree. |
As a plan to finish the report feature, I propose we
Please let me know any comments. |
Usage: >> from dataprep.eda import create_report >> create_report(df) Resolve sfu-db#171
We have added stats info to our plot function, now we can use all those information to generate an HTML page for our users.
I prototyped this layout without adding any practical plots, so we can change this design easily.
Every element is 1:1 to our current code's definition, I believe this may give you a better concept of how this webpage would look like. The width of page is 1920px.
I will put the prototype here if anyone needs a more detailed inspection. Let me know if you have any suggestions. @jnwang @jinglinpeng @dovahcrow @Waterpine @brandonlockhart
https://www.figma.com/file/txfQwkocxBOFOilPvaI9MC/Untitled?node-id=0%3A1
The text was updated successfully, but these errors were encountered: