Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Connector: Add additional authentication method that adds token as query string. #200

Closed
pallavibharadwaj opened this issue Jun 24, 2020 · 0 comments · Fixed by #207
Closed

Data Connector: Add additional authentication method that adds token as query string. #200

pallavibharadwaj opened this issue Jun 24, 2020 · 0 comments · Fixed by #207
Assignees
@pallavibharadwaj
Labels
module: Connector type: enhancement New feature or request

Comments

@pallavibharadwaj
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some websites (Ex: YouTube) allow the authentication token to be added as part of the URL (as a query string parameter) and not as an auth header. Currently, we have two types of authorization: Bearer and OAuth2. Bearer adds the user token as an Authorization header and not as a query string parameter that is expected.

Describe the solution you'd like
When the user provides the auth token while defining the connector object, dc = Connector(".././DataConnectorConfigs/youtube", _auth={"access_token":<auth_token>}), a query string parameter called key is to be added to the params request object.
'params': {'key': 'AIzaSyC2Z29ow99qyV3kdk0CJYTINYgxG48ArqM'}}.

To achieve this, we add an additional type in the config schema called TokenParam along with Bearer and OAuth2 that does this for us in the backend.
@pallavibharadwaj pallavibharadwaj changed the title Add additional authentication method that adds token as query string. Data Connector: Add additional authentication method that adds token as query string. Jun 24, 2020
@pallavibharadwaj pallavibharadwaj self-assigned this Jun 25, 2020
@pallavibharadwaj pallavibharadwaj added the type: enhancement New feature or request label Jun 25, 2020
@pallavibharadwaj pallavibharadwaj mentioned this issue Jun 25, 2020
Open
4 tasks
pallavibharadwaj added a commit to pallavibharadwaj/dataprep that referenced this issue Jun 28, 2020
@pallavibharadwaj
feat(data_connector): adding support for authorization type TokenParam
515f158 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
@pallavibharadwaj pallavibharadwaj mentioned this issue Jun 28, 2020
Merged
10 tasks
pallavibharadwaj added a commit to pallavibharadwaj/dataprep that referenced this issue Jun 28, 2020
@pallavibharadwaj
feat(data_connector): adding support for authorization type TokenParam
b1c4343 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
pallavibharadwaj added a commit to pallavibharadwaj/dataprep that referenced this issue Jul 1, 2020
@pallavibharadwaj
feat(data_connector): adding support for authorization type TokenParam
5273a47 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
pallavibharadwaj added a commit to pallavibharadwaj/dataprep that referenced this issue Jul 4, 2020
@pallavibharadwaj
feat(data_connector): adding support for authorization type TokenParam
9d1fe8d 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
pallavibharadwaj added a commit to pallavibharadwaj/dataprep that referenced this issue Jul 7, 2020
@pallavibharadwaj
feat(data_connector): adding support for authorization type TokenParam
d155e7a 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
kla55 pushed a commit to kla55/dataprep that referenced this issue Jul 23, 2020
@pallavibharadwaj @kla55
feat(data_connector): adding support for authorization type TokenParam
1dcb523 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
devinllu pushed a commit to devinllu/dataprep that referenced this issue Nov 9, 2021
@pallavibharadwaj @dovahcrow
feat(data_connector): adding support for authorization type TokenParam
0bf1448 
The API key gets added as a query string parameter instead of an auth header

Resolves sfu-db#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pallavibharadwaj pallavibharadwaj

Labels
module: Connector type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(data_connector): adding support for authorization type QueryParam pallavibharadwaj/dataprep
1 participant
@pallavibharadwaj