Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eda.plot_correlation): Impelment visualization #11

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

Waterpine
Copy link
Contributor

@Waterpine Waterpine commented Jul 6, 2019

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dovahcrow dovahcrow changed the title feat(eda.plot_correlation): Impelment visualization 🚧 feat(eda.plot_correlation): Impelment visualization Jul 6, 2019
@dovahcrow
Copy link
Member

Add an Intermediate class to eda/common.py.

@dovahcrow
Copy link
Member

Move the shows from vis-* to plot_correlation. So the vis-* funcs only produce figures.

dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot_corr.py Show resolved Hide resolved
dovahcrow
dovahcrow previously approved these changes Jul 8, 2019
dataprep/eda/eda_plot_corr.py Show resolved Hide resolved
@dovahcrow dovahcrow changed the title 🚧 feat(eda.plot_correlation): Impelment visualization feat(eda.plot_correlation): Impelment visualization Jul 8, 2019
@jinglinpeng jinglinpeng merged commit 53dd6f8 into master Jul 9, 2019
dovahcrow pushed a commit that referenced this pull request May 29, 2020
feat(eda.plot_correlation): Impelment visualization
devinllu pushed a commit to devinllu/dataprep that referenced this pull request Nov 9, 2021
feat(eda.plot_correlation): Impelment visualization
fatbuddy added a commit to fatbuddy/dataprep that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants