Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update author_association example #15

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jul 7, 2021

  • comment author's association is event.comment.author_association (issue.author_association is the PR owner, so anyone could make a comment to test a PR if the PR author should have permission)
  • use contains function to simplify check against multiple values

- comment author's association is event.comment.author_association (issue.author_association is the PR owner)
- use contains function to check against multiple values
@sgibson91
Copy link
Owner

Thanks! I copied this from the mybinder docs so it might need updating there too?

@sgibson91
Copy link
Owner

Docker lint is failing a lot at the minute and the output of the action isn't super helpful (it's supposed to comment on the PR, I don't know why it isn't) so I might disable this test.

@sgibson91 sgibson91 merged commit 37d201c into sgibson91:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants