Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Precompute fixed-length string dtypes #12

Open
eric-czech opened this issue Jul 30, 2020 · 1 comment
Open

Precompute fixed-length string dtypes #12

eric-czech opened this issue Jul 30, 2020 · 1 comment

Comments

@eric-czech
Copy link
Collaborator

See https://github.com/pystatgen/sgkit/issues/71.

Max string lengths for string bim/fam entries should be computed before assigning array dtypes.
@tomwhite
Copy link
Collaborator

tomwhite commented Aug 3, 2020

FYI we're doing this for allele lengths in BGEN here: https://github.com/pystatgen/sgkit-bgen/blob/master/sgkit_bgen/bgen_reader.py#L79-L85

eric-czech added a commit to eric-czech/sgkit-plink that referenced this issue Aug 4, 2020
@eric-czech
Precompute string lengths sgkit-dev#12
91e8912
eric-czech added a commit to eric-czech/sgkit-plink that referenced this issue Aug 5, 2020
@eric-czech
Precompute string lengths sgkit-dev#12
0bb862d
This was referenced Aug 5, 2020
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomwhite @eric-czech