Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require.unsee is not exposed in custom require function #85

Closed
notmessenger opened this issue Sep 18, 2015 · 13 comments
Closed

require.unsee is not exposed in custom require function #85

notmessenger opened this issue Sep 18, 2015 · 13 comments

Comments

@notmessenger
Copy link
Contributor

Causes the error of "unable to require.unsee, please upgrade loader.js to >= v3.3.0" to be thrown in the console. See ember-cli/ember-cli-test-loader#15 (comment)

@elwayman02
Copy link
Contributor

@sglanzer any thoughts on this?

@jschilli
Copy link
Collaborator

@elwayman02 have you tried require.unsee = savedRequire.unsee - I suppose we should look at a cleaner proxy on require.

I'm slammed and don't have near term bandwidth to look @ it but PRs or pointers welcome

@elwayman02
Copy link
Contributor

Yea I don't have time to look at it this week at the very least...just heard about it from someone else and it affects stuff I'm working on so I wanted to see if there was any traction here.

@sglanzer-deprecated
Copy link
Owner

We could definitely do some work on a cleaner require proxy - I'm going to do some work on this project again over the next few weeks.

I can dig around the links for steps to reproduce, but if anyone has time to document steps it would be a big help.

@notmessenger
Copy link
Contributor Author

You can run the EmberCli-1.13.8 branch of https://github.com/softlayer/sl-ember-components to replicate the error.

UPDATE: The EmberCli-1.13.8 branch has been deleted but master should have the same issue as it was merged in. Have not confirmed this though.

@sglanzer-deprecated
Copy link
Owner

I haven't seen this in any of my addons, but I'll find some time to look
into this after finishing the addon exclusions work.

On Thu, Oct 8, 2015 at 10:28 AM, Jeremy Brown notifications@github.com
wrote:

You can run the EmberCli-1.13.8 branch of
https://github.com/softlayer/sl-ember-components to replicate the error.


Reply to this email directly or view it on GitHub
#85 (comment)
.

@pixelhandler
Copy link

I'm seeing this error in my addon also test coverage report drastically changed from 93% to 16% seems inaccurate. I did upgrade from ember-cli 1.13.8 to 1.13.13. that's when I noticed this unable to require.unsee, please upgrade loader.js to >= v3.3.0 when running ember t -s

@avdv
Copy link

avdv commented Nov 27, 2015

I did upgrade from ember-cli 1.13.8 to 1.13.13

That's exactly what I was doing, too. Same problem here.

have you tried require.unsee = savedRequire.unsee

That seems to work, thanks @jschilli.

@jagthedrummer
Copy link

I just ran into this issue. Is there any ETA on a fix?

In the mean time where should I add require.unsee = savedRequire.unsee?

@jschilli
Copy link
Collaborator

@jagthedrummer adding that won't change the 1.13.13 issue with accuracy of reporting.

There is a series of changes that change up the way we instrument code that is good with 1.13.13 forward but we're waiting on an upstream dep PR on blanket.js - no action on that yet so we'll need to make a decision about creating a temporary fork.

cc: @sglanzer

@jagthedrummer
Copy link

Ah! Thanks for the info @jschilli. I'm actually on ember-cli 2.2.0-beta.6 and I'm seeing the same error reported above, but I'm also getting no coverage info at all. (Not sure if that's new/useful info...)

jschilli pushed a commit to jschilli/ember-cli-blanket that referenced this issue Feb 19, 2016
jschilli pushed a commit to jschilli/ember-cli-blanket that referenced this issue Feb 19, 2016
jschilli pushed a commit to jschilli/ember-cli-blanket that referenced this issue Feb 19, 2016
jschilli pushed a commit to jschilli/ember-cli-blanket that referenced this issue Feb 27, 2016
@jschilli
Copy link
Collaborator

jschilli commented Mar 4, 2016

Can you retest this with version 0.9.1 (and be sure to update blanket.js via ember g ember-cli-blanket) and reopen if it still persists

@jschilli jschilli closed this as completed Mar 4, 2016
@TaylorHG
Copy link

TaylorHG commented Mar 4, 2016

Been lurking this for a while now

@jschilli your 0.9.1 update solved the issue for me. Thanks a million, you're a rockstar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants