-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require.unsee is not exposed in custom require function #85
Comments
@sglanzer any thoughts on this? |
@elwayman02 have you tried require.unsee = savedRequire.unsee - I suppose we should look at a cleaner proxy on require. I'm slammed and don't have near term bandwidth to look @ it but PRs or pointers welcome |
Yea I don't have time to look at it this week at the very least...just heard about it from someone else and it affects stuff I'm working on so I wanted to see if there was any traction here. |
We could definitely do some work on a cleaner require proxy - I'm going to do some work on this project again over the next few weeks. I can dig around the links for steps to reproduce, but if anyone has time to document steps it would be a big help. |
You can run the EmberCli-1.13.8 branch of https://github.com/softlayer/sl-ember-components to replicate the error. UPDATE: The |
I haven't seen this in any of my addons, but I'll find some time to look On Thu, Oct 8, 2015 at 10:28 AM, Jeremy Brown notifications@github.com
|
I'm seeing this error in my addon also test coverage report drastically changed from 93% to 16% seems inaccurate. I did upgrade from ember-cli 1.13.8 to 1.13.13. that's when I noticed this |
That's exactly what I was doing, too. Same problem here.
That seems to work, thanks @jschilli. |
I just ran into this issue. Is there any ETA on a fix? In the mean time where should I add |
@jagthedrummer adding that won't change the 1.13.13 issue with accuracy of reporting. There is a series of changes that change up the way we instrument code that is good with 1.13.13 forward but we're waiting on an upstream dep PR on blanket.js - no action on that yet so we'll need to make a decision about creating a temporary fork. cc: @sglanzer |
Ah! Thanks for the info @jschilli. I'm actually on ember-cli 2.2.0-beta.6 and I'm seeing the same error reported above, but I'm also getting no coverage info at all. (Not sure if that's new/useful info...) |
Can you retest this with version 0.9.1 (and be sure to update blanket.js via |
Been lurking this for a while now @jschilli your 0.9.1 update solved the issue for me. Thanks a million, you're a rockstar. |
Causes the error of "unable to require.unsee, please upgrade loader.js to >= v3.3.0" to be thrown in the console. See ember-cli/ember-cli-test-loader#15 (comment)
The text was updated successfully, but these errors were encountered: