Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- updated dependency for puppetlabs/stdlib to < 7.0.0 #110

Merged
merged 1 commit into from
May 11, 2020
Merged

- updated dependency for puppetlabs/stdlib to < 7.0.0 #110

merged 1 commit into from
May 11, 2020

Conversation

kmarcroft
Copy link

No description provided.

@kmarcroft kmarcroft mentioned this pull request May 11, 2020
Closed
@cspeterson
Copy link

Since I just came here to make the same PR, I'll add my justification to this one:

Here are all the stdlib functions used in the module and why it's fine to use < 7.0.0

  • ensure_packages(): same
  • ensure_resource(): same
  • concat(): same
  • empty(): deprecated as of Puppet 5.5 but replaced by builtin
  • join(): deprecated as of Puppet 5.4 but replaced by builtin

also, tested and works

@ghoneycutt
Copy link
Collaborator

Thanks @kmarcroft and @cspeterson !!

@ghoneycutt ghoneycutt merged commit ba429f3 into sgnl05:master May 11, 2020
@ghoneycutt
Copy link
Collaborator

Fixes #109

@mat1010 mat1010 mentioned this pull request Sep 29, 2020
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmarcroft @cspeterson @ghoneycutt