Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewport height in BCM VC IV ScreenDriver #97

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

gohai
Copy link
Contributor

@gohai gohai commented Feb 10, 2016

This should fix https://jogamp.org/bugzilla/show_bug.cgi?id=1254, which leads to windowed sketches not being centered in Processing.

gohai added a commit to gohai/processing that referenced this pull request Feb 10, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place.
gohai added a commit to gohai/processing that referenced this pull request Feb 10, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
@gohai
Copy link
Contributor Author

gohai commented Feb 16, 2016

invoking @xranby :)

@gohai
Copy link
Contributor Author

gohai commented Feb 16, 2016

I have a test version of this back-ported to 2.3.2 ready for testing: https://github.com/gohai/processing/commits/arm-jogl-fixes

I'd love to use something like this downstream, but waiting for upstream opinion first ;)

gohai added a commit to gohai/processing that referenced this pull request Mar 15, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
gohai added a commit to gohai/processing that referenced this pull request Mar 15, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
@gohai
Copy link
Contributor Author

gohai commented Mar 30, 2016

@xranby Does this look good to you? Since it this improves usability running non-fullscreen sketches on small screens, like the Raspberry Pi display, I am tempted to try to get Processing to use this patch (as well as #96) on top of 2.3.2.

But I'd feel better if I knew this patch is in upstream JOGL ;)

gohai added a commit to gohai/processing that referenced this pull request Mar 31, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
This should fix https://jogamp.org/bugzilla/show_bug.cgi?id=1254, which leads to windowed sketches not being centered in Processing.
gohai added a commit to gohai/processing that referenced this pull request May 9, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
gohai added a commit to gohai/processing that referenced this pull request May 9, 2016
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97

Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
@gohai gohai closed this Mar 5, 2017
@gohai gohai deleted the bcm-fix-viewportwu branch March 5, 2017 16:17
@gohai gohai restored the bcm-fix-viewportwu branch March 5, 2017 16:17
@gohai gohai reopened this Mar 22, 2017
@sgothel sgothel merged commit 4014713 into sgothel:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants