Add two Raspberry Pi related fixes to JOGL #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is JOGL 2.3.2 with two fixes I wrote on top: sgothel/jogl#96 sgothel/jogl#97 Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
|
If nothing else was changed in JOGL, then I would ahead. |
|
I also tested this change on Windows 10. |
|
Hm, there's a cost to a big binary like this—how soon is the new JOGL due? |
|
There's only been 10 commits since 2.3.2, and the next release is supposed to be 2.4.0 - believe this won't come anytime soon :( |
|
Ouch, ok. Fingers crossed... |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is JOGL 2.3.2 with two fixes I wrote on top:
sgothel/jogl#96
sgothel/jogl#97
Makes the output window centered when using the default closed-source driver on the Raspberry Pi, and adds support for using the new OpenGL driver with the files of the old one still in place. Tested on the Raspbian and OS X.
@benfry @codeanticode
Let me know if we could carry this slightly modified JOGL file till their next upstream release. Should be functionally equivalent on all platforms besides the Pi.