-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re struct #97
Re struct #97
Conversation
sgr-ksmt
commented
Sep 26, 2018
•
edited
Loading
edited
- Support Xcode10 / Swift4.2
- fix travis
- fix bugs
@@ -137,7 +137,7 @@ class PDFGeneratorTests: XCTestCase { | |||
let p3 = PDFPage.imagePath(Mock.imagePath(Mock.ImageName.testImage1)) | |||
let p4 = PDFPage.whitePage(CGSize(width: 100, height: 100)) | |||
let p5 = PDFPage.imageRef(Mock.image(Mock.ImageName.testImage1).cgImage!) | |||
let p6 = PDFPage.binary(UIImagePNGRepresentation(Mock.image(Mock.ImageName.testImage1))!) | |||
let p6 = PDFPage.binary(Mock.image(Mock.ImageName.testImage1).pngData()!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'p6' (identifier_name)
@@ -115,7 +115,7 @@ class ViewController: UIViewController { | |||
try PDFGenerator.generate(pages, to: dst) | |||
} | |||
openPDFViewer(dst) | |||
} catch (let e) { | |||
} catch let e { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)
@@ -89,7 +89,7 @@ class ViewController: UIViewController { | |||
try PDFGenerator.generate(imagePaths, to: dst) | |||
} | |||
openPDFViewer(dst) | |||
} catch (let e) { | |||
} catch let e { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)
@@ -69,7 +69,7 @@ class ViewController: UIViewController { | |||
try PDFGenerator.generate(images, to: dst, dpi: .custom(144), password: "123456") | |||
} | |||
openPDFViewer(dst) | |||
} catch (let e) { | |||
} catch let e { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)
@@ -49,7 +49,7 @@ class ViewController: UIViewController { | |||
try PDFGenerator.generate([v1, v2, v3], to: dst) | |||
} | |||
openPDFViewer(dst) | |||
} catch (let e) { | |||
} catch let e { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)