Merge pull request #3 from purplecabbage/DebugOutput

Debug output
sgrebnov · Nov 21, 2011 · a5e64a3 · a5e64a3
2 parents 3496fb5 + 41ce237
commit a5e64a3
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 24 deletions.
diff --git a/GapAppStarter.zip b/GapAppStarter.zip
diff --git a/README.md b/README.md
@@ -26,7 +26,7 @@ Note!!!
 
 When you add or remove files/folders in the www folder you will need to do the following
 
-- ensure the new item is included in the project ( Content )
+- ensure the new item is included in the project ( Content ) This includes ALL images/css/html/js/* and anything that you want available at runtime.
 -- Do not modify the GapSourceDictionary.xml file which is included in the project, it is auto-generated for you when you build.
 
 

diff --git a/framework/PGView.xaml.cs b/framework/PGView.xaml.cs
@@ -113,7 +113,6 @@ public PGView()
 
 
             StartupMode mode = PhoneApplicationService.Current.StartupMode;
-            Debug.WriteLine("StartupMode mode =" + mode.ToString());
 
             if (mode == StartupMode.Launch)
             {
@@ -317,7 +316,7 @@ void page_BackKeyPress(object sender, CancelEventArgs e)
 
         void GapBrowser_LoadCompleted(object sender, System.Windows.Navigation.NavigationEventArgs e)
         {
-            Debug.WriteLine("GapBrowser_LoadCompleted");
+
         }
 
 
@@ -343,8 +342,6 @@ void GapBrowser_ScriptNotify(object sender, NotifyEventArgs e)
         {
             string commandStr = e.Value;
 
-            Debug.WriteLine("Command::" + commandStr);
-
             // DOMStorage/Local OR DOMStorage/Session
             if (commandStr.IndexOf("DOMStorage") == 0)
             {
@@ -363,7 +360,6 @@ void GapBrowser_ScriptNotify(object sender, NotifyEventArgs e)
             {
                 // ERROR
                 Debug.WriteLine("ScriptNotify :: " + commandStr);
-                return;
             }
             else if (commandCallParams.Service == "CoreEvents")
             {
@@ -374,15 +370,16 @@ void GapBrowser_ScriptNotify(object sender, NotifyEventArgs e)
                         this.OverrideBackButton = (args != null && args.Length > 0 && args[0] == "true");
                         break;
                 }
-                return;
             }
-
-            this.nativeExecution.ProcessCommand(commandCallParams);
+            else
+            {
+                this.nativeExecution.ProcessCommand(commandCallParams);
+            }
         }
 
         private void GapBrowser_Unloaded(object sender, RoutedEventArgs e)
         {
-            //throw new NotImplementedException();
+
         }
 
         private void GapBrowser_NavigationFailed(object sender, System.Windows.Navigation.NavigationFailedEventArgs e)
@@ -392,8 +389,7 @@ private void GapBrowser_NavigationFailed(object sender, System.Windows.Navigatio
 
         private void GapBrowser_Navigated(object sender, System.Windows.Navigation.NavigationEventArgs e)
         {
-            Debug.WriteLine("GapBrowser_Navigated");
-
+
         }
 
 

diff --git a/framework/PhoneGap/Commands/Contacts.cs b/framework/PhoneGap/Commands/Contacts.cs
@@ -181,7 +181,6 @@ private void saveContactTask_Completed(object sender, SaveContactResult e)
         // refer here for contact properties we can access: http://msdn.microsoft.com/en-us/library/microsoft.phone.tasks.savecontacttask_members%28v=VS.92%29.aspx
         public void save(string jsonContact)
         {
-            Debug.WriteLine("Saving Contact :: " + jsonContact);
 
             JSONContact contact = JSON.JsonHelper.Deserialize<JSONContact>(jsonContact);
 
@@ -430,11 +429,6 @@ where a.Contains(searchParams.options.filter)
 
             List<string> contactList = new List<string>();
 
-            foreach(Contact cont in foundContacts)
-            {
-                Debug.WriteLine(cont.ToString() + " : " + cont.DisplayName + " : " + cont.GetHashCode().ToString());
-            }
-
 
             IEnumerable<Contact> distinctContacts = foundContacts.Distinct();
 
@@ -513,8 +507,6 @@ private string FormatJSONContact(Contact con, string[] fields)
 
             jsonContact = "{" + jsonContact + "}";
 
-            //Debug.WriteLine("jsonContact = " + jsonContact);
-
             return jsonContact;
         }
     }

diff --git a/framework/PhoneGap/PluginResult.cs b/framework/PhoneGap/PluginResult.cs
@@ -117,7 +117,6 @@ public string ToJSONString()
                 this.KeepCallback.ToString().ToLower() );
 
             res = "{" + res + "}";
-            //Debug.WriteLine("ToJSONString returning :: " + res);
             return res;
 
 		}

diff --git a/framework/Properties/AssemblyInfo.cs b/framework/Properties/AssemblyInfo.cs
@@ -10,7 +10,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("Microsoft")]
 [assembly: AssemblyProduct("WP7GapClassLib")]
-[assembly: AssemblyCopyright("Copyright © Microsoft 2011")]
+[assembly: AssemblyCopyright("")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -32,4 +32,4 @@
 // You can specify all the values or you can default the Revision and Build Numbers 
 // by using the '*' as shown below:
 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.2.1")]
diff --git a/framework/WP7GapClassLib.csproj b/framework/WP7GapClassLib.csproj
@@ -34,11 +34,13 @@
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
     <OutputPath>Bin\Release</OutputPath>
-    <DefineConstants>TRACE;SILVERLIGHT;WINDOWS_PHONE</DefineConstants>
+    <DefineConstants>DEBUG;TRACE;SILVERLIGHT;WINDOWS_PHONE</DefineConstants>
     <NoStdLib>true</NoStdLib>
     <NoConfig>true</NoConfig>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <DocumentationFile>
+    </DocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="Microsoft.Devices.Sensors" />

diff --git a/template/GapLib/WP7GapClassLib.dll b/template/GapLib/WP7GapClassLib.dll