Reducing the frequency of reloading #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to remove some of |
belcar-s
force-pushed
the
excessive-reloading
branch
3 times, most recently
from
ab73972
to
6427c75
Compare
|
I would love some help (after the holiday, of course!) in getting the elements' identifiers to work. Even when I set them to a constant, files in the sidebar are expanded immediately after the TreeView is reloaded. |
|
@belcar-s Do you think this issue is something we can fix, or is this something specific to Nova? |
|
The identifier issue, I'm not sure. I made a post on the DevForum about it, but it wasn't replied-to. It's very possible that it's my fault, and that I'm misusing the field. |
belcar-s
force-pushed
the
excessive-reloading
branch
from
bf4bca4
to
19016fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes greatly alleviate issue #35. The tree view is now only reloaded…
Demonstration.mp4
I think that this, together with a solution for the
onDidStopChangingproblem, would enable us to provide a very pleasant experience with the sidebar.