Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Page template & CSS rewrite #266
Hijacking my comment to reference changes made or to make on Shaarli's core to handle new templates.
I've added a wrapper function called
or for plural forms
I've added a login form in the header, which requires a token everywhere. A
TODO - EDIT: this is planned in #372
The timezone selects need to be updated to be displayed properly on mobile.
A few plugin placeholders (e.g. in the header) don't work properly with other templates. They need to be reviewed.
TODO - Related to #292
Adding a function to generate URLs would ease later URL maintenance, and will allow to handle an optional URL rewriting properly in the future.
That's very clear. :)
My two cents:
Depending on how this feature is implemented, it would probably be nice with a "standard" place for templates to live. In my current setup I put templates into
In trying to update Shaarli itself, I've discovered that my convention might not be the best, as the Shaarli
I guess for now, although it seems a bit wrong, I'd actually be better off putting my themes into
My first contribution here #74 was actually to move the default template to
For now, you can move your template in the
I recently turned away from server-side generated HTML markup, if there's already XML data. Examples are http://rec.mro.name/stations/m945/2014/06/07/2000%20Breakbeat-Action or https://drop.mro.name/galleries/demo/
I understand that this is quite radical and off mainstream, doesn't work so well for non-content pages (admin stuff) and uses the totally non-hip XSLT, but it's IMO definitively minimalistic to the extreme.
Isn't dropping all server-side templating appealing? What do you think about it?
@mro That's an interesting concept to serve XML data as simply as possible. Although I don't really see how it's relevant here? Since Shaarli doesn't use XML data and is more complicated than just storage, we would have to render XML instead of (x)HTML.
On a side note, I'm spending half my work day doing XSLT these days, and it makes me want to drown kittens. :)
@nodiscc I agree.
I totally agree and invite you to view my two examples #266 (comment) with JS disabled, too.
well, then you could the other half of your day…(duck)
referenced this issue
Feb 17, 2016
Hi guys! I've something more or less working on the webdesign branch. If you could give me some feedback, that would be nice.
The config file is on read-only.
Also, the commit log in the branch is a total mess, I might have to just rebuild it from the start.
While the core functionality (add a link) still works – thanks a lot – the 'delete' breaks: https://travis-ci.org/mro/Shaarli-API-test/jobs/173519278#L221
I'll have a closer look, if there's a chance to get that backward compatible. @ArthurHoaro what do you mean?
@alexisju Myframa uses Material design, which I try not to reproduce here. I think I can get a bit more vanilla result by removing the green bar with the title.
@ArthurHoaro about the
But what puzzles me, is that when installing and testing it, the test fails in an a bit odd way.
Maybe I drop the delete test.
I just checked the demo instance, which I find very nice, and much, much better than the current theme. The overall layout is much cleaner. However, the green color might not suit all tastes. Is there a way to change it without modifying the CSS itself? It would be awesome to be able to define it with a parameter somewhere. If it's hardcoded, then maybe a black/white/grey theme would be safer (think wallabag)?
Hi. I've just discovered the new theme, good idea, it need a cleanup :)
Just checked the demo instance, here a list of problems I found (some of them are question of taste) :
What i like :
@elpiolito Hmm... Maybe it is. Can you add a screenshot to see if we see the same thing?
So I got a lot of useful feedback by asking publicly (see the demo - warning: French), there is still quite a bunch of things to do, but I can see a PR happening by the end of the month.
This new theme is by far nicer than the original one. It's way more modern and way less "geeky" which will help to seduce more users.
Actually, before listing some remarks about it, I'd just like to share a feeling. Even though the work put into it is really impressive, I can't help myself seeing the ghost of the original theme. The structure looks in fact quite similar (almost same top menu, same search with two fields, same filters arranged the same way, same footer, etc.). Wouldn't it have been worth rethinking the whole thing from the beginning? I'm sure the Shaarli community contains people used to deal with User Interfaces and User Experience in general. In the same way developers contribute to the core of the tool, that would be awesome to have some creative people proposing new ideas to improve the usability. I say this especially because I really suck at being creative but I often see wonderful ideas over the internet in terms of webdesign.
Anyhow, I really like this new design and really do not want to look preachy. All this work was absolutely necessary and was greatly done. I just try to start thinking of the future of this amazing tool's appearance.
A few points in disorder:
I really like the new template so far. @ArthurHoaro I believe you addressed most of the criticism found in comments, well done. A few remarks, mostly about grouping items:
About the color scheme, people with different tastes will inevitably want to change it (though I like the default one) so it would be good to provide a way to change major theme colors/provide a custom CSS.
A button to collapse all shaares (collapsing is a nice feature btw) near the
@kalvn Well, I've rewritten the templates, but it's still Shaarli. Also I though it would be nice to have UI consistency between the templates. In any case, all kind of UI improvements can still happen in the future if we get good propositions, but it would probably require core changes, which are out of the scope of this issue.
I think that this issue is covered by the grey/blank background contrast.
It was at first, but I actually got the opposite feedback, to avoid unfortunate miss-click, especially on mobile where the buttons aren't that big. And I kind of like how it is with the delete at the bottom. Still changeable though.
It was also, but it broke titles alignment, and the important information is the title. The orange bar now makes it immediately visible that the link is private.
It's possible, but it would hackish (override the CSS 'on the fly'). I'd rather do that in a plugin.
About the green, I kinda like it, but it was more a random choice in a flat UI colour picker. Although, I wanted a dominant colour to give the theme its identity, and green because the current template uses green also. Unfortunately, the current green doesn't do well as a background. Anyway, the green isn't too present now, but if someone has a better result with another green, I'll look into it.
I think I've covered most of the feedbacks I got. I have to add the latest merged changes, run a W3C check, recreate a clean branch and I'll submit a PR.