Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General discussion #308

Open
nodiscc opened this issue Aug 2, 2015 · 102 comments
Open

General discussion #308

nodiscc opened this issue Aug 2, 2015 · 102 comments

Comments

@nodiscc
Copy link
Member

@nodiscc nodiscc commented Aug 2, 2015

Followup to #44

@nicolasdanelon
Copy link

@nicolasdanelon nicolasdanelon commented Aug 7, 2015

Alright then I got two ideas for shaarli.

  • Add a view private links button (if you click on this link will show only private links)
  • Add a database integrity testing (check old links for URL parameters. Title & description for replace HTML entities
    What do you think ?
@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Aug 8, 2015

Add a view private links button (if you click on this link will show only private links)

But...

privateonly

Add a database integrity testing (check old links for URL parameters. Title & description for replace HTML entities

I'm not sure to understand. You want a system which apply new devs (such as title format) on previous entries?

@nicolasdanelon
Copy link

@nicolasdanelon nicolasdanelon commented Aug 10, 2015

Private links: that button is visible?
Database integrity: just a information check for users who update shaarli from sebsauvage version.

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Aug 16, 2015

Private links: that button is visible?

Yes it should appear when you're logged in. If it doesn't, check that your ad blocker doesn't filter it.

@mro
Copy link

@mro mro commented Aug 18, 2015

Hi all,
a few days ago, I published https://github.com/mro/ShaarliOS on the Apple App Store.

Here are a few codes to get free copies from Apple, please write a comment which one you used and how you like it.

XP73J6J7W4PP A6TNRTAKR4AP F6NTRJLLT64N 396FFEFK4J7F WNEJTK9TYK7F 4RK3F4KH7LWH XHJJ7AXWA49H K7WTHFTLF3F3 ERXFTYWT93FK L349HLFNJT6H

They do expire in 4 weeks.

See also at https://github.com/shaarli/Shaarli/wiki/Community-%26-Related-software#mobile-apps

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Aug 18, 2015

I don't own any Apple device but the screenshots look nice. Good luck with your app! :)

@virtualtam
Copy link
Member

@virtualtam virtualtam commented Aug 18, 2015

Private links: that button is visible?

@nicolasdanelon it is, though it'd be worth having a more explicit button to improve accessibility

ShaarliOS on the Apple App Store

@mro nice ;-)

@fbartels
Copy link

@fbartels fbartels commented Aug 19, 2015

@mro thanks for the promo codes. Just used L349HLFNJT6H.

I will take a deeper look into the app later.

@ParoTheParrot
Copy link

@ParoTheParrot ParoTheParrot commented Aug 24, 2015

ShaarliOS on the Apple App Store: ERXFTYWT93FK - Thanks! 👍

@Eragos
Copy link

@Eragos Eragos commented Aug 27, 2015

@mro instead of taking one of your promocode, I bought your App :) Thanks for your work!

@virtualtam virtualtam mentioned this issue Sep 15, 2015
14 of 20 tasks complete
@mro
Copy link

@mro mro commented Sep 18, 2015

@nodiscc when working on posting new links from an App, I found that it's nowadays hard to detect a successful add. Prior to 35c2c4d the final redirect to the added hash link was a very good indication that the link was really added.

While I understand the wish for a redirect to the link-list after adding (#115), I wonder why it wasn't done via setting the returnurl from the bookmarklet/add link.

@nodiscc what was the reason?

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Sep 18, 2015

@mro the previous behavior was what is described in #115, so that was not ideal either (returning to ?do=addlink). Redirecting to the added link (with an anchor) would also be OK, I guess.

@mro
Copy link

@mro mro commented Sep 18, 2015

Redirecting to the added link (with an anchor) would also be OK, I guess.

that'll be awesome - IMO both in terms of user experience and success verification.

Update: strange - doesn't index.php#1359 look like as if this should be the case already? But when testing, it failed. Also fails on http://shaarlidemo.tuxfamily.org/Shaarli/

@nodiscc Any clues?

mro added a commit to mro/pin4sha.cgi that referenced this issue Sep 18, 2015
@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Dec 24, 2015

Hi,

I have been working on this home server deployment/maintenance tool: https://github.com/nodiscc/srv01 for my own needs. It is still work in progress, but feel free to give it a try. It allows unattended deployment of various services and web applications on a Debian machine (including Shaarli).

It uses ansible and was inspired by sovereign, but focuses on a simplified and more modular setup (deploys only the services you need, leaves out the most complex parts such as the mail server). The full process to install shaarli, after installing a minimal Debian system is:

aptitude install ansible git sudo pwgen python-mysqldb
git clone https://github.com/nodiscc/srv01
cd srv01
nano config.yml #change required configuration values
./srv01 setup #setup the base system
./srv01 install apache
./srv01 install shaarli

As always feedback is welcome.

@mro
Copy link

@mro mro commented Dec 25, 2015

@nodiscc #308 (comment): I shall see this talk soon: https://events.ccc.de/congress/2015/wiki/Lightning:Holo

Anybody interested, should I report?

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Dec 25, 2015

Nice! Yes please, a short report of what you've learned there would be great! Wish I could attend the CCC, if you can send the link to the video of the talk I'd watch it.

For the record I found ansible remarkably easy to use/learn, and powerful enough that it had a built-in solution to every problem I encountered. There are still a number of features (srv01 maintenance...) that I'm considering moving into a shell script (the ansible task is rather convoluted). I prefer ansible/config management over Docker-style maintenance since it uses the system's provided tools/capabilities, I find Docker is a somewhat overengineered implementation of LXC, which is still in it's early ages. In the future I will certainly use plain LXCs to compartmentalize applications services (a good read at https://l3net.wordpress.com/category/virtualization-2/).

@mro
Copy link

@mro mro commented Dec 28, 2015

here's the slides of above talk, I think I will give it a try in the next weeks: https://rawgit.com/holocm/holo-docs/slides/promo/32c3-lightning-talk/slides.pdf

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Jan 18, 2016

I've create a Plugin list page in the wiki, listing 'official' and known 3rd party plugin. Feel free to add your own.

BTW if your plugin is generic enough and if you want to, you can submit a pull request to add it in Shaarli's repo.

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Feb 7, 2016

Should we mirror the git repository somewhere else? There are a few non-profits that offer Git hosting and project management interfaces (GitLab). I was thinking about https://git.framasoft.org and https://git.laquadrature.net/.

@mro
Copy link

@mro mro commented Feb 7, 2016

@nodiscc #308 (comment): for what purpose?

@mro
Copy link

@mro mro commented Feb 7, 2016

ic, as far as I understand (I don't read french) it's considered dangerous to depend on a non-free-software platform.

P.S.: I have a mirror of my fork: http://mirror.mro.name/github.com/mro/Shaarli.git/ for quite some time.

@pips-
Copy link

@pips- pips- commented Jun 12, 2018

Hello everyone,

Do maintainers have any ideas (pros/cons) about publishing shaarli on packagist?

This would allow automatic building of archive versions, and provide another way to install stable branch using something like composer composer create-project shaarli/Shaarli [folder] [version].

Any thoughts?

cheers!

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Jun 12, 2018

Hi,

I've always used packagist to publish libraries which can be used as a dependency and never a whole tool. I didn't know this command (even though I might have used it it to bootstrap Symfony). From the docs:

create-project This is the equivalent of doing a git clone/svn checkout followed by a composer install of the vendors.

I don't mind adding Shaarli to Packagist, but with this command, it would still require to install/build front end dependencies using yarn/npm to work properly.

Also, you can open a separate issue if you're interested in this.

@virtualtam
Copy link
Member

@virtualtam virtualtam commented Jun 13, 2018

This would mostly be interesting if Shaarli could be used as a library to build other PHP applications, in which case it would make more sense to split the current codebase into reusable, vendored libraries, that would be published on Packagist.

Also note that Shaarli has a front-end part that is built using NodeJS/NPM, and is out of Packagist's scope.

@pips-
Copy link

@pips- pips- commented Jun 22, 2018

Hello,

Okay, no problem. No need for a specific issue, I was asking only to know this would have been of any interest to the project.

As I view packagist, it is not only for library, the advantage of using create-project command from composer is to rely only this tool to bootstrap php part, and not rely necessarily on a specific git/svn/other tool.

Even if there is a frontend part, using NodeJS/NPM, this does not seem to be a blocker for packagist, I'm not sure this is really relevant to packagist, but peoples seem to have created composer package for this kind of tool : https://packagist.org/?query=npm

Thanks for your replies. :)

@mfioretti
Copy link

@mfioretti mfioretti commented Sep 3, 2018

hello everybody,

I just opened this issue about shaarli apparently working OK... using a datastore.php file that appears corrupted when read from php on the command line: #1222

thanks in advance for your comments and help

@heimpogo
Copy link

@heimpogo heimpogo commented Apr 9, 2019

Hi, there is a medium refactoring I'd like to suggest:
Have you ever thought about re-packaging the daily view and the tag cloud as plugins? I do not consider these essential. This would allow people to just turn it off it they don't need them.

@kalvn
Copy link

@kalvn kalvn commented Apr 9, 2019

@heimpogo I'm not sure current plugin possibilities would allow to create this kind of pages 🤔

@nicolasdanelon
Copy link

@nicolasdanelon nicolasdanelon commented Apr 9, 2019

@heimpogo why would you do that!? the original shaarli works like that..

@heimpogo
Copy link

@heimpogo heimpogo commented Apr 11, 2019

@kalvn Ok, I didn't check this yet. Thanks for pointing this out.
@nicolasdanelon Shaarli allows very different ways of using it. And some might consider a tag cloud a Web 2.0 relict they don't really need.

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented May 6, 2019

@heimpogo The tag cloud/daily views have no impact on the rest of the application and you can hide those links using custom css, and block access to the pages using .htaccess or other server configuration if you're really into that... But given the fact that they work as expected, have no other implcations, and maintenance time is already thin as is, it's unlikely they will be ported as plugins.

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented May 8, 2019

Github has informed us maintainers that there is a vulnerability in node tar which is included as a dev javascript dependency in Shaarli (CVE-2018-20834).

Vulnerable version of tar is included by node-sass, and fixing this issue is requires sass/node-sass#2625 to be fixed.

I'm not sure what the security implications are, but as it is only a dev dependency, I recommend as a good practice that you remove node_modules folder in production.

You are not impacted if you used the release archive during the install or the Docker image.

@elwinschmitz
Copy link

@elwinschmitz elwinschmitz commented Jun 13, 2019

Re: @heimpogo :

Have you ever thought about re-packaging the daily view and the tag cloud as plugins? I do not consider these essential. This would allow people to just turn it off it they don't need them.

I'd like to +0.5 that. :)
Personally I like the Tag-cloud feature/look, but don't really use the Daily-page or RSS/Atom feeds.

@heimpogo The tag cloud/daily views have no impact on the rest of the application and you can hide those links using custom css, and block access to the pages using .htaccess or other server configuration if you're really into that... But given the fact that they work as expected, have no other implcations, and maintenance time is already thin as is, it's unlikely they will be ported as plugins.

I agree it would be not be worth the effort to completely port them to plugins (as the current plugin-system would need to be changed as well).

But would it be an idea to add some more configuration-options/flags? Like the current setting for Thumbnails? So for example:

  • Enable RSS/Atom feeds
  • Enable Tag-cloud
  • Enable Daily-view

(Or change them around by making them "Disable X").

Then in the templates/routing simple switches could be added, like for example in the menu:

{if="$feature_tag_cloud_enabled"}<a href="?do=tagcloud">Tags</a>{/if}

I'd also like these configuration-options for my own theme, so I could make it usable for other people that would like to use the Daily-view AND my theme. ;)

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Jun 13, 2019

@heimpogo
Copy link

@heimpogo heimpogo commented Jul 14, 2019

A feature request for the markdown plugin: It would be wonderful to have a one-click copy button at the top of code blocks. This would make using Shaarli as a code snippet collection much more comfortable.

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Jul 15, 2019

@heimpogo at the top of each code block inside the shaare? That would be difficult since markdown generation is handled by parsedown, which does a single thing, consuming markdown and returning the corresponding HTML. You would have to open an issue there.

A button to copy the whole shaare description would be doable, but I think it would considerably affect performance (we would have to load the rendered and raw descriptions into the page).

Please correct me if I'm wrong.

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Jul 20, 2019

This shouldn't be done on server side, as you said it would be very difficult.

One easy solution would be to add this Copy-to-Clipboard plugin to my code coloration plugin, which rely on Prism.JS. Note that Prism is not really a lightweight library, as it supports many languages.

@MarceauKa
Copy link

@MarceauKa MarceauKa commented Oct 1, 2019

Hi all!
I built a Shaarli version with Laravel: https://github.com/MarceauKa/laravel-shaarli
At first it was just a 2 hours challenge to train a friend with Laravel but it's now a real package.

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Oct 2, 2019

That's interesting, thank you for sharing!

@virtualtam
Copy link
Member

@virtualtam virtualtam commented Nov 13, 2019

Hey @MarceauKa, and thanks for sharing!

I would strongly advise you to rename your application and source repository though, as naming it after Shaarli is misleading to users:

  • the project is not affiliated with the Shaarli community;
  • there is no shared codebase with the Shaarli application;
  • the project is not on-par with Shaarli feature-wise (e.g. Netscape import/export, Docker images, documentation);
  • the underlying technologies (save the choice of the PHP language) are different.

Thanks for your understanding :)

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented Nov 13, 2019

This is also what I strongly recommended here awesome-selfhosted/awesome-selfhosted#1864. It is misleading.

@MarceauKa
Copy link

@MarceauKa MarceauKa commented Nov 14, 2019

@virtualtam @nodiscc
Yep, it was planned but it needs time to rename an application. It's done, Laravel Shaarli is now Shaark

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented May 1, 2020

milestone

the future is now

@nodiscc
Copy link
Member Author

@nodiscc nodiscc commented May 1, 2020

Moved from #1446:

I'm proud to announce a new version of the iOS share extension. 🍏 📱

For those who want to give it a try, there's free copies at mro/ShaarliOS#40

Pinging #308 and #323
Happy shaaring! 🎉

@nodiscc nodiscc added this to the backlog to the future milestone May 1, 2020
@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Oct 22, 2020

Cute:

@ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Oct 27, 2020

There have been quite a few new features for v0.12.1, which I plan to release in one or two weeks.
I have pushed all remaining issues (with milestone v0.12.1) tagged as feature for v0.12.2.

@Arthinsx
Copy link

@Arthinsx Arthinsx commented Feb 22, 2021

Hello

I want to use the plugin system to add some new data. So I check how it works in the demo pluggin for the data "Stuff". But it seems it does not work properly because when I save a new value in the stuff property I can't retrieve it when I try to edit the link.

I look directly in the datastore.php file and I can't see any new value added in the file either.

I'm not sure I'm doing right. Is that functionality available already ? Is that a bug ?

For information, CONTRIBUTING.md indicates that the general discussion is in #44 (you should update to #308).

@Knah-Tsaeb
Copy link

@Knah-Tsaeb Knah-Tsaeb commented Mar 1, 2021

Already report #1646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet