Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor thumbnail functions #345

Closed
13 tasks
virtualtam opened this issue Sep 6, 2015 · 2 comments · Fixed by #687
Closed
13 tasks

Refactor thumbnail functions #345

virtualtam opened this issue Sep 6, 2015 · 2 comments · Fixed by #687
Labels
cleanup code cleanup and refactoring enhancement in review thumbnail media thumbnails
Milestone
0.10.0

Comments

@virtualtam
Copy link
Member

Todolist

Refactoring

  • move the following functions to application/Thumbnail.php:
    • computeThumbnail
    • genThumbnail
    • lazyThumbnail
    • resizeImage
    • thumbnail
  • add test coverage
  • apply coding conventions

Improvements

  • factorize genThumbail (duplicated code)
  • refactor calls to 'get_http_url'
    • handle Exception in calling code
    • update unitary tests
  • parametrizable thumbnail size
@virtualtam virtualtam added enhancement in progress cleanup code cleanup and refactoring labels Sep 6, 2015
@virtualtam virtualtam self-assigned this Sep 6, 2015
@virtualtam virtualtam added this to the 0.5.5 milestone Sep 6, 2015
This was referenced Sep 6, 2015
Closed
Merged
@rubykat
Copy link

rubykat commented Sep 30, 2015

While you're doing this, I think it would be a good idea to make the thumbnail size configurable, rather than hard-coded to 100 pixels high.

@nodiscc nodiscc mentioned this issue Oct 28, 2015
Closed
@virtualtam
Copy link
Member Author

@rubykat good point, added to the TODO-list ;-)

@virtualtam virtualtam modified the milestones: 0.6.1, 0.6.2 Nov 22, 2015
@virtualtam virtualtam modified the milestones: 0.6.2, 0.6.3 Dec 3, 2015
@virtualtam virtualtam modified the milestones: 0.6.3, 0.6.4 Dec 23, 2015
@virtualtam virtualtam modified the milestones: 0.6.4, 0.7.0 Feb 17, 2016
@ArthurHoaro ArthurHoaro added the thumbnail media thumbnails label Feb 25, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.7.1 May 14, 2016
@ArthurHoaro ArthurHoaro removed this from the 0.7.0 milestone May 14, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.8.0, 0.10.0 Jul 27, 2016
@virtualtam virtualtam mentioned this issue Oct 16, 2016
Closed
20 tasks
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 9, 2016
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
61c9370 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 9, 2016
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
9950053 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
@ArthurHoaro ArthurHoaro mentioned this issue Nov 9, 2016
Merged
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Dec 8, 2016
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
69eaabe 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 11, 2017
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
04e21c2 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 11, 2017
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
03e6766 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 17, 2017
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
9ef1d57 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
@virtualtam virtualtam removed their assignment Feb 14, 2018
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Mar 31, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
fce1243 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue May 5, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
9177101 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue May 5, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
5c02a79 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jun 8, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
ebf5818 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jul 5, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
11daf2b 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jul 5, 2018
@ArthurHoaro
Use web-thumbnailer to retrieve thumbnails
1b93137 
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup code cleanup and refactoring enhancement in review thumbnail media thumbnails
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Use web-thumbnailer to retrieve thumbnails ArthurHoaro/Shaarli
3 participants
@rubykat @virtualtam @ArthurHoaro