forked from sebsauvage/Shaarli
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template - Add a way to detect whether a link has a thumbnail or not #487
Labels
Milestone
Comments
As advised on the issue mentioned above, the following code do the trick:
I guess the issue can be closed. |
You can keep it open I think. That's something that's need to be done with thumbnail refactoring. |
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Nov 9, 2016
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Nov 9, 2016
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Dec 8, 2016
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Nov 11, 2017
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Nov 11, 2017
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Nov 17, 2017
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Mar 31, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
May 5, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
May 5, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Jun 8, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Jul 5, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Jul 5, 2018
* requires PHP 5.6 * use blazy on linklist since a lot more thumbs are retrieved * thumbnails can be disabled * thumbs size is now 120x120 * thumbs are now cropped to fit the expected size Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
Fixed by #687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my theme, I had the following issue: kalvn/Shaarli-Material#31
And I cannot properly fix it as I put the thumbnail in a container but I have no clean way to know whether a link has a thumbnail or not. Therefore, I cannot apply different styling rules depending on this, and since I display the image as a left float, it cause issues if the description of the link includes a background or a border (as it's the case for markdown blockquotes).
And since the thumbnail is populated through a RainTPL filter, I have no way of testing if the filter will return something or not.
Would it be possible to add such possibility? For example by running the filter before the rendering and then add a new parameter like
$value.thumbnail
.The text was updated successfully, but these errors were encountered: