Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template - Add a way to detect whether a link has a thumbnail or not #487

Closed
kalvn opened this issue Feb 18, 2016 · 3 comments
Closed

Template - Add a way to detect whether a link has a thumbnail or not #487

kalvn opened this issue Feb 18, 2016 · 3 comments
Labels
enhancement template HTML rendering thumbnail media thumbnails
Milestone

Comments

@kalvn
Copy link

kalvn commented Feb 18, 2016

In my theme, I had the following issue: kalvn/Shaarli-Material#31

And I cannot properly fix it as I put the thumbnail in a container but I have no clean way to know whether a link has a thumbnail or not. Therefore, I cannot apply different styling rules depending on this, and since I display the image as a left float, it cause issues if the description of the link includes a background or a border (as it's the case for markdown blockquotes).

And since the thumbnail is populated through a RainTPL filter, I have no way of testing if the filter will return something or not.

Would it be possible to add such possibility? For example by running the filter before the rendering and then add a new parameter like $value.thumbnail.

@ArthurHoaro ArthurHoaro added this to the 0.7.0 milestone Feb 18, 2016
@kalvn
Copy link
Author

kalvn commented Feb 23, 2016

As advised on the issue mentioned above, the following code do the trick:

{$thumb=thumbnail($value.url)}
{if="$thumb==false"}yay{/if}

I guess the issue can be closed.

@ArthurHoaro
Copy link
Member

You can keep it open I think. That's something that's need to be done with thumbnail refactoring.

@ArthurHoaro ArthurHoaro added the thumbnail media thumbnails label Feb 25, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.7.1 May 14, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.8.0, 0.10.0 Jul 27, 2016
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 9, 2016
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 9, 2016
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Dec 8, 2016
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 11, 2017
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 11, 2017
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 17, 2017
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
@virtualtam virtualtam modified the milestones: 0.10.0, 0.10.2 Jan 10, 2018
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Mar 31, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue May 5, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue May 5, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jun 8, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jul 5, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jul 5, 2018
  * requires PHP 5.6
  * use blazy on linklist since a lot more thumbs are retrieved
  * thumbnails can be disabled
  * thumbs size is now 120x120
  * thumbs are now cropped to fit the expected size

Fixes shaarli#345 shaarli#425 shaarli#487 shaarli#543 shaarli#588 shaarli#590
@ArthurHoaro
Copy link
Member

Fixed by #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement template HTML rendering thumbnail media thumbnails
Projects
None yet
Development

No branches or pull requests

3 participants