Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "nomarkdown" tag is no longer private #582

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented May 30, 2016

A private tag is never loaded for visitor, making this feature useless.

This tag is no longer private, but always hidden in linklist.

From Gitter:

@nodiscc: I've read about a possible bug in the markdown plugin, just a reminder to check for this http://shaarli.guiguishow.info/?PAenmg
@ArthurHoaro: Oh. That was stupid. The .nomarkdown tag is private, so it's never loaded for visitors.

EDIT: backquotes in the commit message didn't work very well.

A private tag is never loaded for visitor, making this feature useless.
@ArthurHoaro ArthurHoaro added bug it's broken! plugin bells and whistles in review labels May 30, 2016
@ArthurHoaro ArthurHoaro added this to the 0.7.1 milestone May 30, 2016
@ArthurHoaro ArthurHoaro self-assigned this May 30, 2016
@ArthurHoaro ArthurHoaro changed the title The tag is no longer private The "nomarkdown" tag is no longer private May 30, 2016
@nodiscc
Copy link
Member

nodiscc commented May 31, 2016

Why hide the tag at all?

@ArthurHoaro
Copy link
Member Author

Because it's a technical tag, which has no meaning regarding links content.

@ArthurHoaro ArthurHoaro merged commit bb9ca54 into shaarli:master Jun 6, 2016
@ArthurHoaro ArthurHoaro deleted the hotfix/nomarkdown branch June 6, 2016 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! plugin bells and whistles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants