Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Port/server config problems #98

Merged
merged 1 commit into from
Jan 26, 2015
Merged

Fixes Port/server config problems #98

merged 1 commit into from
Jan 26, 2015

Conversation

ArthurHoaro
Copy link
Member

Fixes Port/server config problems - see: #17

  • Use SERVER_NAME instead of HTTP_HOST to define current URL (in serverUrl()
  • Use SERVER_NAME instead of HTTP_HOST while setting up cookies

@ArthurHoaro
Fixes Port/server config problems - see: shaarli#17
2f32d07 
  * Use SERVER_NAME instead of HTTP_HOST to define current URL (in serverUrl()
  * Use SERVER_NAME instead of HTTP_HOST while setting up cookies
@nodiscc nodiscc added bug it's broken! please test labels Jan 9, 2015
@nodiscc
Copy link
Member

nodiscc commented Jan 26, 2015

I don't know yet if this fixes reverse proxy problems. But using SERVER_NAME insetad of HTTP_HOST makes sense and there is no regression. I'll merge this and wait for feedback in sebsauvage#101 sebsauvage#132 sebsauvage#180 sebsauvage#183 sebsauvage#186 sebsauvage#60 sebsauvage#209 sebsauvage#165.

Thanks @ArthurHoaro

nodiscc added a commit that referenced this pull request Jan 26, 2015
@nodiscc
Merge pull request #98 from ArthurHoaro/port
09850e6 
Fix port/server config problems by using php SERVER_NAME instead of HTTP_HOST
@nodiscc nodiscc merged commit 09850e6 into shaarli:master Jan 26, 2015
This was referenced Jan 26, 2015
Closed
Closed
@ArthurHoaro ArthurHoaro deleted the port branch January 29, 2015 19:35
@virtualtam virtualtam added the proxy hosting behind reverse proxies label Aug 23, 2015
@virtualtam virtualtam mentioned this pull request Aug 23, 2015
Closed
@ArthurHoaro ArthurHoaro mentioned this pull request May 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug it's broken! please test proxy hosting behind reverse proxies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurHoaro @nodiscc @virtualtam