Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stripEndings translation edge cases #176

Closed
Harjot1Singh opened this issue Nov 2, 2020 · 0 comments · Fixed by #178
Closed

stripEndings translation edge cases #176

Harjot1Singh opened this issue Nov 2, 2020 · 0 comments · Fixed by #178
Assignees
@bhajneet
Labels
Effort 1 Simple task (code/non-code). ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@Harjot1Singh
Copy link
Member

Describe the bug
Some translations have numbers, such as 8.4 million mid-line. This causes it to be detected as a line ending and then everything including it onwards is removed, incorrectly.

To Reproduce
stripEndings( 'Through 8.4 million incarnations you have wandered' ) => Through

Expected behavior
stripEndings( 'Through 8.4 million incarnations you have wandered' ) => Through 8.4 million incarnations you have wandered
@Harjot1Singh Harjot1Singh added ○ Type Bug Regressions/production issues that do not function as intended. Effort 1 Simple task (code/non-code). Status: To Do labels Nov 2, 2020
bhajneet added a commit to bhajneet/gurmukhi-utils that referenced this issue Nov 2, 2020
@bhajneet
fix(stripEndings): constrain number stripping to end of lines
6401423 
fix shabados#176
@bhajneet bhajneet mentioned this issue Nov 2, 2020
Merged
Harjot1Singh pushed a commit that referenced this issue Nov 2, 2020
@bhajneet
fix(stripEndings): constrain number stripping to end of lines (#178)
4adbf3f 
Fixes #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhajneet bhajneet

Labels
Effort 1 Simple task (code/non-code). ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stripEndings): constrain number stripping to end of lines bhajneet/gurmukhi-utils
2 participants
@Harjot1Singh @bhajneet