Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stripEndings): constrain number stripping to end of lines #178

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

bhajneet
Copy link
Member

@bhajneet bhajneet commented Nov 2, 2020

Summary of PR

Lines with "8.4 million" in it would have everything afterwards (including self) stripped away

Tests for unexpected behavior

  • none_whatsoever

Time spent on PR

one hour

Linked issues

Fix #176

Reviewers

@Harjot1Singh

@bhajneet bhajneet added ○ Type Bug Regressions/production issues that do not function as intended. Effort 1 Simple task (code/non-code). Impacts Few Does not affect many end-users. labels Nov 2, 2020
@coveralls
Copy link

coveralls commented Nov 2, 2020

Pull Request Test Coverage Report for Build 342054087

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 336089287: 0.0%
Covered Lines: 153
Relevant Lines: 153

💛 - Coveralls

Copy link
Member

@Harjot1Singh Harjot1Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@Harjot1Singh Harjot1Singh merged commit 4adbf3f into shabados:dev Nov 2, 2020
@bhajneet bhajneet deleted the bhajneet/issue176 branch January 11, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 1 Simple task (code/non-code). Impacts Few Does not affect many end-users. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stripEndings translation edge cases
3 participants