Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up project #109

Merged
merged 27 commits into from
Sep 15, 2020
Merged

Clean up project #109

merged 27 commits into from
Sep 15, 2020

Conversation

Harjot1Singh
Copy link
Member

@Harjot1Singh Harjot1Singh commented Sep 11, 2020

Summary of PR

Cleans up the project:

  • Remove unused dependencies and files (Watermelon DB + Data Manager)
  • Update all dependencies
  • Improve development experience (npm run start:ios/android will run tests and typescript in watch mode)
  • Figure out TS .ios, .android resolution
  • Fix tests
  • Sort out Typescript linting rules
  • Fix types
  • Fix Jest triggering itself/ignored directory list

Tests for unexpected behavior

  • none_whatsoever

Time spent on PR

12 hours

Linked issues

Fix #100

Reviewers

@saihaj @bhajneet

@Harjot1Singh
Copy link
Member Author

@saihaj could you please test Android? I do not know if I removed too much from MainApplication.java

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2020

This pull request introduces 2 alerts and fixes 1 when merging 86dcb63 into 1789057 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran this locally:

  • iOS build succeed
  • Android need to modify the main file to fix, once you make those changes it will succeed.

To update to latest gradle version (3.6.3) we must update android/build.gradle Line 16 with classpath('com.android.tools.build:gradle:3.6.3')

For some reason when I do gh pr checkout 109 it creates a local branch that is not connected to this branch (it wants me to push it to my GH fork) so unfortunately I can't push code to this branch : (

@Harjot1Singh
Copy link
Member Author

Please re-check android when you get a chance

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2020

This pull request introduces 2 alerts and fixes 1 when merging d63f5cf into 1789057 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@saihaj
Copy link
Member

saihaj commented Sep 11, 2020

npm run start:android

@saihaj
Copy link
Member

saihaj commented Sep 11, 2020

Need to address this:
image

@Harjot1Singh
Copy link
Member Author

Android and iOS resolution will be resolved and furthermore used in the project by creating a Component.d.ts file, with either:

export * from './Component.ios or export { default } from './Component.ios'

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request fixes 1 alert when merging 77a00e8 into 1789057 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request fixes 1 alert when merging b2dbc83 into 21a40a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request fixes 1 alert when merging d20090c into 21a40a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request fixes 1 alert when merging d09704c into 21a40a1 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@Harjot1Singh Harjot1Singh merged commit bd059b0 into shabados:dev Sep 15, 2020
@Harjot1Singh Harjot1Singh deleted the 100-clean-project branch September 15, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up/re-boostrap codebase
3 participants