-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up project #109
Clean up project #109
Conversation
@saihaj could you please test Android? I do not know if I removed too much from |
This pull request introduces 2 alerts and fixes 1 when merging 86dcb63 into 1789057 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran this locally:
- iOS build succeed
- Android need to modify the main file to fix, once you make those changes it will succeed.
To update to latest gradle version (3.6.3) we must update android/build.gradle
Line 16 with classpath('com.android.tools.build:gradle:3.6.3')
For some reason when I do gh pr checkout 109
it creates a local branch that is not connected to this branch (it wants me to push it to my GH fork) so unfortunately I can't push code to this branch : (
Please re-check android when you get a chance |
This pull request introduces 2 alerts and fixes 1 when merging d63f5cf into 1789057 - view on LGTM.com new alerts:
fixed alerts:
|
|
Android and iOS resolution will be resolved and furthermore used in the project by creating a
|
This pull request fixes 1 alert when merging 77a00e8 into 1789057 - view on LGTM.com fixed alerts:
|
0587559
to
b2dbc83
Compare
This pull request fixes 1 alert when merging b2dbc83 into 21a40a1 - view on LGTM.com fixed alerts:
|
b2dbc83
to
d20090c
Compare
This pull request fixes 1 alert when merging d20090c into 21a40a1 - view on LGTM.com fixed alerts:
|
Prettier-Eslint plugin appears to have issues with Eslint 7.x See https://rohit.page/blog/posts/how-to-get-prettier-eslint-play-nicely-with-vscode/
This pull request fixes 1 alert when merging d09704c into 21a40a1 - view on LGTM.com fixed alerts:
|
Summary of PR
Cleans up the project:
npm run start:ios/android
will run tests and typescript in watch mode).ios
,.android
resolutionTests for unexpected behavior
Time spent on PR
12 hours
Linked issues
Fix #100
Reviewers
@saihaj @bhajneet