Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom fields to payload after action is called no longer working? #102

Open
jlhonora opened this issue Mar 29, 2016 · 1 comment
Open

Custom fields to payload after action is called no longer working? #102

jlhonora opened this issue Mar 29, 2016 · 1 comment

Comments

@jlhonora
Copy link

I believe that inserting custom fields in a before_filter action is no longer working (See PR #24 for previous work).

I tried making a test to replicate it but it seems there are no tests for custom field insertion in the payload, only for context ones. Commit e0f0312 (by @frankel) seems to be the culprit, this situation has a conflict with the exception use case.

Any ideas on how we can make both use cases coexist? Thanks in advance, great lib.
@jlhonora
Copy link
Author

Related to issue #61 as well.

@jlhonora jlhonora mentioned this issue Mar 30, 2016
Closed
51326 pushed a commit to 51326/logstasher that referenced this issue Oct 18, 2016
@Jadeno
Add custom fields to payload AFTER action is called
cebf114 
related issues
- Add custom fields to payload AFTER action is called [shadabahmed#24](shadabahmed#24)
- Custom fields to payload after action is called no longer working? [shadabahmed#102](shadabahmed#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlhonora