Add custom fields to payload AFTER action is called #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadabahmed
added a commit
that referenced
this pull request
Mar 7, 2014
Add custom fields to payload AFTER action is called
|
Thanks for this 👍 |
|
Updated logstasher to version 0.5.0 for this. Thanks 👍 |
51326
pushed a commit
to 51326/logstasher
that referenced
this pull request
Oct 18, 2016
related issues - Add custom fields to payload AFTER action is called [shadabahmed#24](shadabahmed#24) - Custom fields to payload after action is called no longer working? [shadabahmed#102](shadabahmed#102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine we want to log the user id or some session variables, this will be called before any before_filter, including the rails before filter that handles csrf.
This can be bad, for example, devise memoizes the current resource, this means that if we want to add
current_user.idto the custom fields, it will be computed before rails can nullify the session (default behaviour), meaning that CSRF protection will be completely bypassed.