Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Scalafmt #323

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Introduce Scalafmt #323

merged 2 commits into from
Feb 3, 2020

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Jan 27, 2020 •
edited
Loading

Comment on the first commit and the 2nd commit is generated by sbt style.
The code format is checked on CI via sbt styleCheck.

@joan38
Copy link
Contributor Author

joan38 commented Jan 30, 2020

Please ignore conflicts as I will rebase and apply the style once the formatting config is agreed.

@shadaj shadaj added this to the v0.6.4 milestone Jan 31, 2020
shadaj
shadaj requested changes Jan 31, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add continuationIndent.defnSite = 2, includeCurlyBraceInSelectChains = false, and project.git = true to the config? Those have worked well in previous projects.

@joan38
Copy link
Contributor Author

joan38 commented Feb 3, 2020

Done

shadaj
shadaj approved these changes Feb 3, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shadaj shadaj merged commit 1a99b52 into shadaj:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@joan38 @shadaj