Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Scalafmt #323

Merged
merged 2 commits into from Feb 3, 2020
Merged

Introduce Scalafmt #323

merged 2 commits into from Feb 3, 2020

Conversation

@joan38
Copy link
Contributor

joan38 commented Jan 27, 2020

Comment on the first commit and the 2nd commit is generated by sbt style.
The code format is checked on CI via sbt styleCheck.

@joan38

This comment has been minimized.

Copy link
Contributor Author

joan38 commented Jan 30, 2020

Please ignore conflicts as I will rebase and apply the style once the formatting config is agreed.

@shadaj shadaj added this to the v0.6.4 milestone Jan 31, 2020
Copy link
Owner

shadaj left a comment

Could we add continuationIndent.defnSite = 2, includeCurlyBraceInSelectChains = false, and project.git = true to the config? Those have worked well in previous projects.

@shadaj shadaj force-pushed the shadaj:master branch from 3d85f66 to b66eca0 Jan 31, 2020
@joan38 joan38 force-pushed the joan38:scalafmt branch from 2464c49 to 521167f Feb 3, 2020
@joan38

This comment has been minimized.

Copy link
Contributor Author

joan38 commented Feb 3, 2020

Done

@shadaj
shadaj approved these changes Feb 3, 2020
Copy link
Owner

shadaj left a comment

Looks great!

@shadaj shadaj merged commit 1a99b52 into shadaj:master Feb 3, 2020
7 checks passed
7 checks passed
test (ubuntu-latest, 0.6.31)
Details
test (ubuntu-latest, 1.0.0-RC2)
Details
test (windows-latest, 0.6.31)
Details
test (windows-latest, 1.0.0-RC2)
Details
build-docs
Details
build-intellij-plugin
Details
publish
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.