-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): Add Table component #248
Conversation
@multiwebinc is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This looks great. I've been testing |
Since This component looks OK, but it would be nice if there were more colors to choose from. There are a couple of issues open about that, so if you let me know what direction you want to head, I would be willing to work on a PR for that as well if you like. |
Hey, if you want I can give tanstack table a look and make a PR |
I vote for using |
I vote to support this, have a simple Table, then differentiate the name (Table vs DataGrid vs other) to fulfill both or more community expectations down the road. Edit: Whoa and what just shipped recently also the Data Table with TanStack Table https://ui.shadcn.com/examples/tasks |
Thanks for the suggestions. As @multiwebinc said, making tanstack-table the default would be overkill for most app. I suggest we move forward with @multiwebinc |
@multiwebinc I'm going ahead and merge this. I have some more updates in another branch incoming. Thank you. |
@multiwebinc I pushed table and data table yesterday. Couldn't find you on Twitter to credit you for starting the work on table. But I merged this PR so you should get the commit credit. HMU on Twitter if you're around. |
* Add table.tsx * Update table.tsx --------- Co-authored-by: shadcn <m@shadcn.com>
* Add table.tsx * Update table.tsx --------- Co-authored-by: shadcn <m@shadcn.com>
No description provided.