Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): Add Table component #248

Merged
merged 4 commits into from
May 8, 2023
Merged

Conversation

multiwebinc
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 25, 2023

@multiwebinc is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:47am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Visit Preview May 8, 2023 11:47am

@shadcn
Copy link
Collaborator

shadcn commented Apr 26, 2023

This looks great. I've been testing tanstack-table integration. I'll give this a try with this component and report back.

@multiwebinc
Copy link
Contributor Author

Since tanstack-table might be overkill for simple tables, you might want to consider adding it as a separate component, sort of like how MUI has Table for simple tables and DataGrid for more advanced uses.

This component looks OK, but it would be nice if there were more colors to choose from. There are a couple of issues open about that, so if you let me know what direction you want to head, I would be willing to work on a PR for that as well if you like.

@Rugz007
Copy link

Rugz007 commented Apr 26, 2023

This looks great. I've been testing tanstack-table integration. I'll give this a try with this component and report back.

Hey, if you want I can give tanstack table a look and make a PR

@willopez
Copy link

I vote for using tanstack-table and have a basic example that people can build upon.

@mhaidarhanif
Copy link

mhaidarhanif commented Apr 27, 2023

@multiwebinc Since tanstack-table might be overkill for simple tables, you might want to consider adding it as a separate component, sort of like how MUI has Table for simple tables and DataGrid for more advanced uses.

I vote to support this, have a simple Table, then differentiate the name (Table vs DataGrid vs other) to fulfill both or more community expectations down the road.

Edit: Whoa and what just shipped recently also the Data Table with TanStack Table

https://ui.shadcn.com/examples/tasks
https://ui.shadcn.com/docs/components/data-table

@shadcn
Copy link
Collaborator

shadcn commented Apr 29, 2023

Thanks for the suggestions.

As @multiwebinc said, making tanstack-table the default would be overkill for most app.

I suggest we move forward with @multiwebinc <Table /> primitive and add tanstack-table as an example.

@skonky skonky linked an issue Apr 30, 2023 that may be closed by this pull request
@shadcn
Copy link
Collaborator

shadcn commented May 8, 2023

@multiwebinc I'm going ahead and merge this. I have some more updates in another branch incoming. Thank you.

@shadcn shadcn merged commit 9a6b934 into shadcn-ui:main May 8, 2023
@shadcn
Copy link
Collaborator

shadcn commented May 10, 2023

@multiwebinc I pushed table and data table yesterday. Couldn't find you on Twitter to credit you for starting the work on table. But I merged this PR so you should get the commit credit.

HMU on Twitter if you're around.

suleymanbariseser pushed a commit to suleymanbariseser/shadcn-ui that referenced this pull request Jul 25, 2023
* Add table.tsx

* Update table.tsx

---------

Co-authored-by: shadcn <m@shadcn.com>
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
* Add table.tsx

* Update table.tsx

---------

Co-authored-by: shadcn <m@shadcn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Table Component
5 participants