fix: remove event propagation between iframe and resizable component #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wontory is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
It seems to be a cross-browsing issue. Windows Chrome: works Relatedbvaughn/react-resizable-panels#64 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've found that the preview's
Resizablecomponent in the block page isn't functioning correctly due to event propagation between theResizablecomponent and theiframe.In this PR, I've fixed the issue by adding the
pointer-events-noneclass to the iframe whenisDraggingof theResizableHandlecomponent istrue, thereby preventing event propagation.Before
CleanShot.2024-05-21.at.11.09.06.mp4
After
CleanShot.2024-05-21.at.11.11.06.mp4