-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dark Mode Guide for Vite with React #750
base: main
Are you sure you want to change the base?
Conversation
|
@CarlosZiegler is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the same layout with the Tabs as the vite-docs (check this PR #714). Also remove the ThemeVite.gif
and the package-lock.json
.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@dan5py updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the titles from the tabs content?
… and empty lines ✨ feat(dark-mode.mdx): add support for dark mode in Next.js and Vite with React
@dan5py updated |
@dan5py and @CarlosZiegler , rather than this being on the installation page what if we make the dark mode page similar to instalation page and show tabs for next.js remix and vite dark mode configuration ? |
@NikharPandya I was thinking the same thing. |
@dan5py I could help to implement that. |
Is there a PR open for this? I recommend using the existing |
Can we implement the dark mode using react and javascript? |
Here the docs : |
This PR adds a guide for implementing dark mode in a Vite project with React. The guide includes the following steps:
The guide is intended to be clear and easy to follow, allowing developers to implement dark mode in their Vite and React projects effectively.
Please review and let me know if any changes are required.
PS: Added a GIF but I am not so familiar to put it into MDX when work on github CODESPACES :(