Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-decoration-skip-ink #4

Closed
notabene opened this issue Jan 14, 2020 · 3 comments
Closed

text-decoration-skip-ink #4

notabene opened this issue Jan 14, 2020 · 3 comments

Comments

@notabene
Copy link

@notabene notabene commented Jan 14, 2020

Hi Shadeed,

Impressive genuine documentation here!

For underline text decoration I was wondering if you had tested text-decoration-skip-ink?

It works well for Latin languages, so I was thinking maybe it's a good thing to add to your document. It's not supported everywhere yet but it's promising, but I don't know how well it behaves for Arabic below-word signs such as curves and dots.

@shadeed

This comment has been minimized.

Copy link
Owner

@shadeed shadeed commented Jan 14, 2020

Hello, Thanks a lot for reading!

I will study it and test that asap, will ping you there once I push something. Thanks for the heads up.

@shadeed shadeed transferred this issue from shadeed/rtl-styling-issues Jan 16, 2020
shadeed added a commit that referenced this issue Jan 18, 2020
@shadeed

This comment has been minimized.

Copy link
Owner

@shadeed shadeed commented Jan 18, 2020

Hello @notabene , I just pushed an update for text-decoration. Your point was valid and it helped me to enhance the section. Thanks a lot 🙏Let me know please if all is good, so I can close this issue.

@notabene

This comment has been minimized.

Copy link
Author

@notabene notabene commented Jan 19, 2020

I considered it more as one solution among others than the only one but you're the boss! 😉

Glad I could help!

@notabene notabene closed this Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.