Improve diagnostics for overlapping/conflicting bindings #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Change overlapping bindings case from error to warning (it is technically allowed in HLSL/GLSL)
Make diagnostic messages for these cases include a note to point at the "other" declaration in each case, so that user can more easily isolate the problem
Unrelated fix: make sure
slangc
sets up its diagnostic callback before parsing command-line options so that error messages output during options parsing will be visibleUnrelated fix: make sure that formatting for diagnostic messages doesn't print diagnostic ID for notes (all have IDs < 0).