Mesh shader refactoring and bugfixes #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
approved these changes
Mar 8, 2024
| // It's illegal to not write out the entire primitive at once, so limit | ||
| // this to set | ||
| [mutating] | ||
| __intrinsic_op($(kIROp_MeshOutputSet)) |
There was a problem hiding this comment.
We maybe able to get rid of this opcode by having set call __getMeshOutputRef() = newValue;
| SLANG_ASSERT(ptr && "Mesh output parameter was passed by value"); | ||
| auto t = ptr->getValueType(); | ||
| auto tmp = builder->emitVar(t); | ||
| for(UInt i = 0; i < c->getOperandCount(); i++) |
There was a problem hiding this comment.
Can we use c->getArg and c->setArg instead?
| @@ -26,7 +26,7 @@ const static uint MAX_VERTS = 3; | |||
| const static uint MAX_PRIMS = 1; | |||
|
|
|||
| // Test that we can convert the HLSL Syntax to the typed syntax | |||
| void foo(uint tig, out Vertices<Vertex, MAX_VERTS> verts) | |||
| void foo(uint tig, OutputVertices<Vertex, MAX_VERTS> verts) | |||
There was a problem hiding this comment.
Why are we removing the test for the out Vertices syntax?
|
This looks close to beeing mergable. I have great interest in using the enhancements in this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2804 and #3401