Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All binaries are now always installed /bin and /sbin #196

Closed
chutz opened this issue Dec 1, 2019 · 4 comments
Closed

All binaries are now always installed /bin and /sbin #196

chutz opened this issue Dec 1, 2019 · 4 comments

Comments

@chutz
Copy link
Contributor

chutz commented Dec 1, 2019

Some distros still care about /bin vs /usr/bin. The change e293aa9 makes it so all binaries are always installed to /bin//sbin. The only way to restore the previous behaviour of installing some binaries to /usr/bin//usr/sbin is to revert the patch.
@hallyn
Copy link
Member

hallyn commented Dec 1, 2019

Hm. I'll have to look in a bit - I don't know why I didn't think it was doing that.

Please feel free to do a PR doing the revert.

chutz added a commit to chutz/shadow that referenced this issue Dec 1, 2019
@chutz
Revert "Honor --sbindir and --bindir for binary installation"
3cc3948 
This reverts commit e293aa9.

See shadow-maint#196

Some distros still care about `/bin` vs `/usr/bin`. This commit makes
it so all binaries are always installed to `/bin`/`/sbin`. The only way to
restore the previous behaviour of installing some binaries to
`/usr/bin`/`/usr/sbin` is to revert the patch.
@chutz chutz mentioned this issue Dec 1, 2019
Merged
@chutz
Copy link
Contributor Author

chutz commented Dec 1, 2019

Maybe the "right" solution to get the behaviour I suspect you were aiming for is to have a --binprefix configure flag. Have it default to prefix, but allow it to be overridden.

@hallyn
Copy link
Member

hallyn commented Dec 2, 2019

Thanks, merged the revert, so closing this.

@hallyn hallyn closed this as completed Dec 2, 2019
@hallyn
Copy link
Member

hallyn commented Dec 2, 2019

If you need a 4.8.1 release with this revert, please shout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chutz @hallyn