Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id(1) and groups(1) #1008

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented May 29, 2024

Distributions use id(1) from GNU coreutils or BusyBox. Drop ours.

Closes: #1005
Suggested-by: @dkwo
Cc: @hallyn
Cc: @ikerexxe
Cc: @jubalh
Cc: @thesamesam


Revisions:

v1b
  • Rebase
$ git range-diff master..gh/idgroups shadow/master..idgroups 
1:  8e856bbd = 1:  ba31ca7b Remove id(1)
v1c
  • Rebase
$ git range-diff alx/master..gh/idgroups shadow/master..idgroups 
1:  ba31ca7b = 1:  b2cec0be Remove id(1)
v2
  • Remove groups(1)
$ git range-diff shadow/master gh/idgroups idgroups 
1:  b2cec0be = 1:  b2cec0be Remove id(1)
-:  -------- > 2:  451debfe Remove groups(1)
v2b
  • Rebase
$ git range-diff master..gh/idgroups shadow/master..idgroups 
1:  b2cec0be ! 1:  61d117c4 Remove id(1)
    @@ src/id.c (deleted)
     -#include <stdio.h>
     -#include <sys/types.h>
     -
    --#include "alloc.h"
    +-#include "alloc/malloc.h"
     -#include "defines.h"
     -
     -/* local function prototypes */
2:  451debfe ! 2:  a539c303 Remove groups(1)
    @@ src/groups.c (deleted)
     -#include <pwd.h>
     -#include <stdio.h>
     -
    --#include "alloc.h"
    +-#include "alloc/x/xmalloc.h"
     -#include "defines.h"
     -#include "prototypes.h"
     -#include "shadowlog.h"

@alejandro-colomar

This comment was marked as outdated.

@alejandro-colomar alejandro-colomar marked this pull request as ready for review May 29, 2024 13:04
@ikerexxe
Copy link
Collaborator

I think we should do an announcement in a release notes indicating that we are deprecating it. Once that is done and nobody has complained we can proceed to remove it.

@alejandro-colomar
Copy link
Collaborator Author

alejandro-colomar commented May 29, 2024

I think we should do an announcement in a release notes indicating that we are deprecating it. Once that is done and nobody has complained we can proceed to remove it.

Okay. I'll then prepare the patch for groups(1) already, and will make this a draft, ready for when the announcement is done.

@alejandro-colomar alejandro-colomar marked this pull request as draft May 29, 2024 13:24
@alejandro-colomar alejandro-colomar marked this pull request as ready for review June 30, 2024 08:16
@alejandro-colomar alejandro-colomar changed the title Remove id(1) Remove id(1) and groups(1) Jul 1, 2024
Distributions use id(1) from GNU coreutils or BusyBox.  Drop ours.

Closes: <shadow-maint#1005>
Suggested-by: dkwo <nicolopiazzalunga@gmail.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Iker Pedrosa <ipedrosa@redhat.com>
Cc: Michael Vetter <jubalh@iodoru.org>
Cc: Sam James <sam@gentoo.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
@hallyn hallyn merged commit 866d911 into shadow-maint:master Jul 2, 2024
9 checks passed
@alejandro-colomar alejandro-colomar deleted the idgroups branch July 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecating and removing groups(1) and id(1)
3 participants