usermod: allow all group types with -G option #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way of removing a group from the supplementary list is to use -G option, and list all groups that the user is a member of except for the one that wants to be removed. The problem lies when there's a user that contains both local and remote groups, and the group to be removed is a local one. As we need to include the remote group with -G option the command will fail. This reverts commit 140510d. This way, it would be possible to remove the remote groups from the supplementary list. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1967641 Resolves: shadow-maint#338 Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
|
So then to replace 140510d, would you want to add an extra cli flag pair to separately specify local/remote groups? |
|
No, I think it would be best for usermod to only check the group type if there's a real change to process. For example: to add a new group. If the group was already present nothing should be done about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way of removing a group from the supplementary list is to use
-G option, and list all groups that the user is a member of except for
the one that wants to be removed. The problem lies when there's a user
that contains both local and remote groups, and the group to be removed
is a local one. As we need to include the remote group with -G option
the command will fail.
This reverts commit 140510d. This way,
it would be possible to remove the remote groups from the supplementary
list.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1967641
Resolves: #338
Signed-off-by: Iker Pedrosa ipedrosa@redhat.com