Groupmod fixes #607
Groupmod fixes #607
Conversation
The buffers have a size of 512 (see xmalloc() above), which is what snprintf(3) expects. Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This is shorter to write than 'unsigned long int', so we can collapse some lines. It is guaranteed by C99. Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
groupmod_fixes
branch
from
5dce89b
to
7ce5b88
Compare
|
Changes: added link to PR in commit message |
This is shorter to write than 'unsigned long int', so we can collapse some lines. It is guaranteed by C99. Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
groupmod_fixes
branch
from
7ce5b88
to
3972eb1
Compare
|
Changes: Added missing |
There was a problem hiding this comment.
LGTM
@hallyn @ikerexxe I need to add functions that are usable in the entire project; we've seen that some parts of the project don't use libmisc, right? In which library should I put them? Or can we make the entire project depend on libmisc?
I think it's fine to add those general functions in libmisc and make the entire project depend on this library.
Thanks!
Could you please do that step of making libmisc globally available? I have little idea of the organization of the project. I'll start writing patches that don't need that, while I wait for that to be done. |
|
Unfortunately, I don't think I'll have time this year, but I'll try to accommodate some time. |
The buffers have a size of 512 (see xmalloc() above), which is what snprintf(3) expects. Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This is shorter to write than 'unsigned long int', so we can collapse some lines. It is guaranteed by C99. Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
Link: <shadow-maint#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
groupmod_fixes
branch
from
3972eb1
to
90a35a7
Compare
The buffers have a size of 512 (see xmalloc() above), which is what snprintf(3) expects. Link: <#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This is shorter to write than 'unsigned long int', so we can collapse some lines. It is guaranteed by C99. Link: <#607> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This is a preparation patch before some more fixes. I found some problems in this file, which are not yet addressed by these fixes. This is only cleaning up so that the more important fixes are more readable.
@hallyn @ikerexxe I need to add functions that are usable in the entire project; we've seen that some parts of the project don't use libmisc, right? In which library should I put them? Or can we make the entire project depend on libmisc?