F adding component to watchdog #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces into F_refactoring_watchdog
…ces into F_adding_component_to_watchdog
…ces into F_adding_component_to_watchdog
beatrizleon
suggested changes
Jul 5, 2019
| new_log.type = log[1] | ||
| system_status.logs.append(new_log) | ||
|
|
||
| if 10 < len(self.watchdog_logs): |
There was a problem hiding this comment.
I think it is better to not have this magic constant number as the 10. Better to have a parameter to define it and be able to change it if we want to
sr_watchdog/package.xml
Outdated
| <description>The sr_watchdog package</description> | ||
| <author email="michal@shadowrobot.com">Michal Kramarczyk</author> | ||
| <maintainer email="software@shadowrobot.com">Shadow Robot Software Team</maintainer> | ||
| <license>GPL</license> |
| @@ -0,0 +1,86 @@ | |||
| #!/usr/bin/env python | |||
| # | |||
| # Copyright (C) 2017, 2018 Shadow Robot Company Ltd - All Rights Reserved. | |||
There was a problem hiding this comment.
wrong license? should be public?
beatrizleon
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating watchdog to handle components and multiple classes
Types of changes
What types of changes does your code introduce?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have: