Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting to new xacros #29

Merged
merged 10 commits into from
Nov 29, 2021
Merged

Adjusting to new xacros #29

merged 10 commits into from
Nov 29, 2021

Conversation

mikramarc
Copy link
Contributor

@mikramarc mikramarc commented Nov 19, 2021

Proposed changes

Adjusting autodetector to pass in new flags to work with new xacros. Some additional cleanup.

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added automated tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

include/sr_hand_detector/sr_hand_detector.h Show resolved Hide resolved
{
detect_hands();
compose_command_suffix();
std::string result;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should check if vec size is 0 and return None?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just assuming there might be an extreme case in which people are able to lunch a hand with no fingers (e.g. phantom). if that is not possible in the xacro launch then should be ok.

src/sr_hand_detector/sr_hand_autodetect.cpp Show resolved Hide resolved
@biofotis biofotis merged commit fefc021 into noetic-devel Nov 29, 2021
@biofotis biofotis deleted the F_adjusting_to_new_xacros branch November 29, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants