Process: remove "hasn't started" state #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
sporksmith
force-pushed
the
process-refactor-start
branch
from
e5bc705
to
fde0782
Compare
stevenengler
approved these changes
Apr 13, 2023
This also drops the performance timer for creating the thread group leader.
The handler really only existed and worked for our defunct ptrace-based implementation. Remove it until it's actually supported. Fixes shadow#2718
This also removes `Process::has_started`; there is no longer such a thing as a `Process` that hasn't been started.
sporksmith
force-pushed
the
process-refactor-start
branch
from
fde0782
to
e3f5609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor so that we create and start the Process's first thread before we actually create the Process object. This lets us remove some fields from Process that are only needed when starting the Process, and remove some Option wrappers around other fields that were previously only populated after start.
I think this is generally an improvement, but in particular is nice to get done before further implementing #2034, and I think will also be helpful for implementing fork.