Refactor Process teardown #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
sporksmith
force-pushed
the
process-refactor-cleanup
branch
from
4964e6a
to
4fcae33
Compare
github-actions
bot
removed
the
Component: Documentation
stevenengler
approved these changes
Apr 14, 2023
Now that we're directly notified of thread exit, we don't need to "poll" thread liveness.
Pass "Process exited" event up call stack instead of reaching up object hierarchy to mutate state.
Completely remove the Process::is_exiting field; we handle process exit synchronously now, so don't need to have this extra state.
Pass this through the call stack instead of having it another state variable.
sporksmith
force-pushed
the
process-refactor-cleanup
branch
from
4fcae33
to
a09ba44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Process to remove more state variables and make process teardown easier to follow.