Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tgen nix Flake #21

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Add a tgen nix Flake #21

merged 4 commits into from
Dec 16, 2021

Conversation

sporksmith
Copy link
Contributor

@sporksmith sporksmith commented Dec 8, 2021

This is mostly useful when using tgen as part of a larger nix configuration, e.g. to specify a reproducible environment for an experiment.

It can also be used to install tgen using the nix package manager. e.g. once merged, a user with the nix package manager installed could use: nix profile install github:shadow/tgen. (nix profile install github:sporksmith/tgen/flake should already work now)

@sporksmith sporksmith changed the title Flake Add a tgen nix Flake Dec 13, 2021
@sporksmith sporksmith marked this pull request as ready for review December 13, 2021 21:51
Copy link
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some documentation - at least a rough overview of how we might maintain the flake bits, since I'm going to assume most devs would not have much experience. (No need to re-review, unless you want another.)

@sporksmith
Copy link
Contributor Author

Thanks! I asked eta @ tor if she could take a look since she has some experience with nix; I'll wait and see if she does before merging.

We should add some documentation - at least a rough overview of how we might maintain the flake bits

I intentionally avoided adding anything to the user docs yet since this is a bit of an experiment. We might decide next month or next week that nix isn't worth maintaining for us and rip it back out.

I'll make a pass to see if I can add some more comments about maintenance. Since this adds CI we can probably mostly ignore it if it doesn't break, though I suppose we ought to update the lock file and nix channel version occasionally.

@sporksmith sporksmith merged commit b3bc6c4 into shadow:main Dec 16, 2021
@sporksmith sporksmith deleted the flake branch December 16, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants