Generate certificates valid during shadow's emulated time #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporksmith
force-pushed
the
faketime
branch
2 times, most recently
from
8a180ef
to
9f885d8
Compare
tor currently doesn't care if certificates were generated in the future, at least for testing networks, but arti does. Since it's relatively easy to generate certificates that are valid during the simulation's emulated time, this seems preferable vs adding a test-only path in arti.
robgjansen
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tor currently doesn't care if certificates were generated in the future,
at least for testing networks, but arti does. Since it's relatively easy
to generate certificates that are valid during the simulation's emulated
time, this seems preferable vs adding a test-only path in arti.