-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new Shadow configuration formats #8
Conversation
Shadow made a change where each process launches with its cwd set to the shadow.data/host/name directory rather than the cwd used to launch shadow. We updated paths to config files to stay consistent with this change. The change first happened in: shadow/shadow@dac7013
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me!
tornettools/generate_defaults.py
Outdated
@@ -30,6 +27,8 @@ | |||
TOR_DIR_PORT=8080 | |||
TOR_GUARD_MIN_CONSBW=2000 | |||
|
|||
PROC_ENV="OPENSSL_ia32cap=~0x200000200000000;EVENT_NOSELECT=1;EVENT_NOPOLL=1;EVENT_NOKQUEUE=1;EVENT_NODEVPOLL=1;EVENT_NOEVPORT=1;EVENT_NOWIN32=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember, but did we decide that Tor actually doesn't need any of these env variables to be set in order to work correctly? If so, should we simplify and remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added them only because they were there originally. The OPENSSL_ia32cap=~0x200000200000000
to disable hardware AES might be useful once we have a preload that skips encryption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we decided here that preloading the AES cipher does not actually improve performance, so it's easier to just not deal with the extra complexity of another preload library. Without a preload, I think we would want to enable hardware AES to make sure it's as efficient as possible, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about that. I've removed these environment variables.
No description provided.