Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @shadowhand,
I hope you're doing well.
I've figured out the current
SelectQuery
does not allow to resetlimit()
andoffset()
(their definitions do not allownull
values). The only way to reset them is to set them to0
, but here's what it does with an example use case:Here's what it currently produces:
The 2nd statement is not valid SQL (at least, MySQL kicks me out) because the intended behaviour was not to set the limit and offset to
0
but to remove these parts from the query.The solution
With this PR null values will be allowed:
Now outputs:
BC breaks
Will now output:
But at least this is now valid SQL.