Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullable order by to clear out the order #77

Merged
merged 3 commits into from Dec 28, 2018
Merged

Allow nullable order by to clear out the order #77

merged 3 commits into from Dec 28, 2018

Conversation

felixpenrose
Copy link
Contributor

No description provided.

shadowhand
shadowhand requested changes Dec 20, 2018
View reviewed changes
Copy link
Owner

@shadowhand shadowhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This needs a test and documentation before it can be merged.

@felixpenrose
Copy link
Contributor Author

Is the latest commit what you were after?

shadowhand
shadowhand approved these changes Dec 21, 2018
View reviewed changes
Copy link
Owner

@shadowhand shadowhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small suggestion then it can go in.

docs/query-select.md Show resolved Hide resolved
@shadowhand
Update docs/query-select.md
81e1076 
Co-Authored-By: felixpenrose <felix.penrose@gap360.com>
@shadowhand shadowhand merged commit 1a7f6f3 into shadowhand:master Dec 28, 2018
@shadowhand
Copy link
Owner

Released in version 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowhand shadowhand shadowhand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixpenrose @shadowhand